This repository was archived by the owner on Nov 26, 2025. It is now read-only.
FQDN in CNAME needs to be fully qualified to root#153
Open
nickpiggott wants to merge 2 commits intoebu:developfrom
Open
FQDN in CNAME needs to be fully qualified to root#153nickpiggott wants to merge 2 commits intoebu:developfrom
nickpiggott wants to merge 2 commits intoebu:developfrom
Conversation
The FQDN must end in a . character to determine that it's at root, not a subdomain / hostname. This change appends a . to the FQDN before outputting to the zone file, if it hasn't already been captured in user input.
FQDN in CNAME needs to be fully qualified to root
Member
|
This applies to the 'export zone' function for channels in a service provider |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The FQDN must end in a . character to determine that it's at root, not a subdomain / hostname.
This change appends a . to the FQDN before outputting to the zone file, if it hasn't already been captured in user input.