Add option to disable warning on MSVC about symbol visibility for cus… #163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsjbailey
force-pushed
the
optionally_silence_msvc_warnings
branch
from
550a077 to
1c5a4ad
Compare
tomjnixon
reviewed
Sep 14, 2022
| target_link_libraries(adm PRIVATE $<BUILD_INTERFACE:rapidxml>) | ||
|
|
||
| if(ADM_DISABLE_MSVC_EXCEPTION_DLL_BOUNDARY_WARNINGS) | ||
| target_compile_options(adm PUBLIC $<$<CXX_COMPILER_ID:MSVC>:/DADM_DISABLE_MSVC_EXCEPTION_DLL_BOUNDARY_WARNINGS=1>) |
Member
There was a problem hiding this comment.
please indent this, and maybe use target_compile_definitions? looks good otherwise.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…tom exceptions
Currently, on MSVC builds, we have a lot of warnings about the custom adm extensions being derived from std::exception, despite this being listed as a 'best practice' in the msvc documentation.
As these exceptions are defined in a header, this will not be an issue for direct consumers of libadm. We think this would only be an issue for transitive dependants if the direct dependent allows the exception definition to propogate out, and the ABI for std::exception changes, and the consumer is using a different version of the compiler than that with which is was built (or debug/release mismatch) - a combination which is fairly unlikely.
To err on the side of caution, this PR leaves the warnings enabled by default, but provides a cmake option that disables these warnings for this specific case. It also enables this option for CI builds, to avoid noise that might obscure more pertinent issues.