Skip to content

[WIP] Fix return value when get agent hosting pool #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tc1989tc wants to merge 1 commit into
base: devel
Choose a base branch
from
Open

[WIP] Fix return value when get agent hosting pool #84

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion neutron/extensions/lbaas_agentscheduler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,8 +88,12 @@ def index(self, request, **kwargs):
"get_%s" % LOADBALANCER_AGENT,
{},
plugin=lbaas_plugin)
return lbaas_plugin.get_lbaas_agent_hosting_pool(

agent = lbaas_plugin.get_lbaas_agent_hosting_pool(
request.context, kwargs['pool_id'])
if not agent:
agent = {'agent': []}
return agent

@huntxu huntxu Apr 1, 2017

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

应该到get_lbaas_agent_hosting_pool的实现里面改会比较好，那里的返回比较清晰。

另外agent是个单数，所以应该是{'agent': None}返回成json是{'agent': null}

我不是很熟悉RESTful的东西，感觉确实应该保持一致，建议你先提交到上游看看。如果上游觉得没问题我们也就没必要修复了

@tc1989tc tc1989tc Apr 1, 2017

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

开始也想在里面改,,, 结果一看 有好几个地方都调用了get_lbaas_agent_hosting_pool....

@huntxu huntxu Apr 1, 2017

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

所以其实是plugin只用了一个函数分别提供给rest的api和对rpc的api的问题，先看看上游是否觉得这个返回值是个bug吧，如果算是再说。

@tc1989tc tc1989tc Apr 1, 2017

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

恩 看了哈 最新的依然没有改动...



class Lbaas_agentscheduler(extensions.ExtensionDescriptor):
Expand Down