Skip to content

Ensure AmberTools will find the correct python library and include dir#4045

Merged
boegel merged 2 commits intoeasybuilders:developfrom
Crivella:fix-amber_pythonlibs
Jan 28, 2026
Merged

Ensure AmberTools will find the correct python library and include dir#4045
boegel merged 2 commits intoeasybuilders:developfrom
Crivella:fix-amber_pythonlibs

Conversation

@Crivella
Copy link
Copy Markdown
Contributor

Addresses failure of building AmberTools on EESSI

AmberTools uses find_package(PythonLibs) which has been deprecated (require different hints than the one we currently set for python in CMake).

With this changes we provide the dedicated hints for it to find the correct library and include directory.

@Crivella Crivella added bug fix EESSI Related to EESSI project labels Jan 15, 2026
version = get_software_version('Python')
shlib_ext = get_shared_lib_ext()
self.cfg.update('configopts', '-DDOWNLOAD_MINICONDA=FALSE')
self.cfg.update('configopts', '-DPYTHON_EXECUTABLE=%s' % os.path.join(pythonroot, 'bin', 'python'))
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed as this is now set by the CMake configure_step

@Crivella Crivella marked this pull request as ready for review January 15, 2026 10:00
@Crivella
Copy link
Copy Markdown
Contributor Author

@boegelbot please test @ jsc-zen3
EB_ARGS="--installpath /tmp/$USER/ebpr-4045 AmberTools-23.6-foss-2023a.eb AmberTools-24.10-foss-2024a.eb AmberTools-25.2-foss-2025a.eb"

@boegelbot
Copy link
Copy Markdown

@Crivella: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=4045 EB_ARGS="--installpath /tmp/$USER/ebpr-4045 AmberTools-23.6-foss-2023a.eb AmberTools-24.10-foss-2024a.eb AmberTools-25.2-foss-2025a.eb" EB_CONTAINER= EB_REPO=easybuild-easyblocks EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_4045 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 9459

Test results coming soon (I hope)...

Details

- notification for comment with ID 3777460910 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown

boegelbot commented Jan 21, 2026

Test report by @boegelbot

Overview of tested easyconfigs (in order)

Build succeeded for 0 out of 3 (total: 3 mins 53 secs) (3 easyconfigs in total)
jsczen3c2.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.7, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.23
See https://gist.github.com/boegelbot/65e9bdab0620efded5273cfe489d1d30 for a full test report.

NOTES

== 2026-01-21 11:14:35,951 run.py:637 INFO Output of 'python ...' shell command (stdout + stderr):
NoInternetAccess: Cannot connect to https://ambermd.org
Preparing to apply specific updates... please wait.

🫤
Will have to retry when their servers are back online

@branfosj
Copy link
Copy Markdown
Member

== 2026-01-21 11:14:35,951 run.py:637 INFO Output of 'python ...' shell command (stdout + stderr):
NoInternetAccess: Cannot connect to https://ambermd.org
Preparing to apply specific updates... please wait.


🫤 Will have to retry when their servers are back online

I proposed easybuilders/easybuild-easyconfigs#23747 last time that site was down and also to allow fully offline builds. See also #3900 and #3901

@Crivella
Copy link
Copy Markdown
Contributor Author

@boegelbot please test @ jsc-zen3
EB_ARGS="--installpath /tmp/$USER/ebpr-4045 AmberTools-23.6-foss-2023a.eb AmberTools-24.10-foss-2024a.eb AmberTools-25.2-foss-2025a.eb"

@boegelbot
Copy link
Copy Markdown

@Crivella: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=4045 EB_ARGS="--installpath /tmp/$USER/ebpr-4045 AmberTools-23.6-foss-2023a.eb AmberTools-24.10-foss-2024a.eb AmberTools-25.2-foss-2025a.eb" EB_CONTAINER= EB_REPO=easybuild-easyblocks EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_4045 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 9468

Test results coming soon (I hope)...

Details

- notification for comment with ID 3784582058 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown

Test report by @boegelbot

Overview of tested easyconfigs (in order)

  • SUCCESS AmberTools-23.6-foss-2023a.eb

  • SUCCESS AmberTools-24.10-foss-2024a.eb

  • SUCCESS AmberTools-25.2-foss-2025a.eb

Build succeeded for 3 out of 3 (total: 5 hours 20 mins 42 secs) (3 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.7, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.23
See https://gist.github.com/boegelbot/564fc1213a3d3eec03505de2a7ac44a1 for a full test report.

@boegel boegel added this to the next release (5.2.1?) milestone Jan 28, 2026
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel merged commit df450c3 into easybuilders:develop Jan 28, 2026
22 checks passed
@Crivella Crivella deleted the fix-amber_pythonlibs branch January 28, 2026 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug fix EESSI Related to EESSI project

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants