fix compatibility of ROOT easyblock with search-path-cpp-headers option#3973
Open
lexming wants to merge 1 commit intoeasybuilders:developfrom
Open
fix compatibility of ROOT easyblock with search-path-cpp-headers option#3973lexming wants to merge 1 commit intoeasybuilders:developfrom
search-path-cpp-headers option#3973lexming wants to merge 1 commit intoeasybuilders:developfrom
Conversation
jfgrimm
reviewed
Jan 9, 2026
| for header_var in header_vars: | ||
| header_paths = os.getenv(header_var, "") | ||
| new_header_paths = [p for p in header_paths.split(os.pathsep) if p != llvm_inc] | ||
| if new_header_paths: |
Member
There was a problem hiding this comment.
I don't think this would ever evaluate to False?
If header_paths is an empty string, then new_header_paths will be [''], which is truthy
Contributor
Author
There was a problem hiding this comment.
there is one case, if all paths in header_paths are already in llvm_inc, then new_header_paths = []
Contributor
Author
There was a problem hiding this comment.
you are right than an empty string in header_paths will pass through though, that needs fixing
boegel
changed the title
search-path-cpp-headers option
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix for ROOT related to issue #3969
edit: requires:
search_path_vars_headersandsearch_path_vars_linkerproperties toToolchaineasybuild-framework#5031