Skip to content

Feat/fix callback type checks #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
HuangFeiPeng wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Feat/fix callback type checks #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c6b59b5
feat(@easemob/web-antd): 添加安全回调函数检查以防止非函数类型被调用
HuangFeiPeng Jan 15, 2026
faf5ea8
chore(@easemob/web-antd): 恢复 InteractionManager 和 setImmediate 的相关注释
HuangFeiPeng Jan 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/react-native-chat-uikit/src/biz/hooks/useCloseAlert.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,9 @@ export function useCloseAlert(props: UseCloseAlertProps) {
const { alertRef } = props;
const closeAlert = React.useCallback(
(onFinished?: () => void) => {
const _onFinished = typeof onFinished === 'function' ? onFinished : undefined;
alertRef.current?.close?.(() => {
onFinished?.();
_onFinished?.();
});
},
[alertRef]
Expand Down
3 changes: 2 additions & 1 deletion packages/react-native-chat-uikit/src/biz/hooks/useCloseMenu.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,9 @@ export function useCloseMenu(props: UseCloseMenuProps) {
const { menuRef } = props;
const closeMenu = React.useCallback(
(onFinished?: () => void) => {
const _onFinished = typeof onFinished === 'function' ? onFinished : undefined;
menuRef.current?.startHide?.(() => {
onFinished?.();
_onFinished?.();
});
},
[menuRef]
Expand Down
40 changes: 22 additions & 18 deletions packages/react-native-chat-uikit/src/ui/Modal/SlideModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,20 +48,7 @@ export function SlideModal(props: SlideModalProps) {

if (propsRef.current) {
propsRef.current.startShow = (onf?: () => void, timeout?: number) => {
setVisible(true);
setTimeout(() => {
if (timeout !== undefined) {
startShow(() => {
timeoutTask(timeout, () => {
onf?.();
});
});
} else {
startShow(() => {
onf?.();
});
}
}, 16); // one frame's delay
// 使用 InteractionManager 确保动画在主线程执行
// InteractionManager.runAfterInteractions(() => {
// if (timeout !== undefined) {
// startShow(() => {
Expand All @@ -75,15 +62,31 @@ export function SlideModal(props: SlideModalProps) {
// });
// }
// });
const _onf = typeof onf === 'function' ? onf : undefined;
setVisible(true);
setTimeout(() => {
if (timeout !== undefined) {
startShow(() => {
timeoutTask(timeout, () => {
_onf?.();
});
});
} else {
startShow(() => {
_onf?.();
});
}
}, 16); // one frame's delay

if (timeout !== undefined) {
startShow(() => {
timeoutTask(timeout, () => {
onf?.();
_onf?.();
});
});
} else {
startShow(() => {
onf?.();
_onf?.();
});
}
};
Expand Down Expand Up @@ -133,18 +136,19 @@ export function SlideModal(props: SlideModalProps) {
// }, 50);
// });
// }
const _onf = typeof onf === 'function' ? onf : undefined;
if (timeout !== undefined) {
startHide(() => {
setVisible(false);
timeoutTask(timeout, () => {
onf?.();
_onf?.();
onFinished?.();
});
});
} else {
startHide(() => {
setVisible(false);
onf?.();
_onf?.();
onFinished?.();
});
}
Expand Down