Compatibility with older version of virt-install#3
Open
anesheret wants to merge 5 commits intoearlruby:mainfrom
Open
Compatibility with older version of virt-install#3anesheret wants to merge 5 commits intoearlruby:mainfrom
anesheret wants to merge 5 commits intoearlruby:mainfrom
Conversation
anesheret
commented
Jul 31, 2023
* Ubuntu 20.04.6 LTS - compatibility
* Using `cloud-localds` - as described in cloud-init documentation
* `virsh` - auto remove all associated storage volumes
holmanb
suggested changes
Nov 15, 2023
holmanb
left a comment
There was a problem hiding this comment.
- Using
cloud-localds- as described in cloud-init documentation
But why?
cloud-localds is a wrapper around genisoimage, and cloud-utils isn't shipped to as many distros as genisoimage. The only benefit to cloud-localds, as I see it, is that it has a simpler command line invocation, but for a script like this that benefit is lost.
Also, information in the commit message about how virt-install fails and which version the change was made in would be valuable for reviewers and future users of this script.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.