[#24244] Hide terminator scrollbars

[Danipiza]

This PR adds Terminator support to TerminalSession so scrollbars are hidden during VulcanAI execution and restored afterward, matching the existing GNOME behavior pattern.

[Copilot]

Pull request overview

This PR improves terminal UX output and expands terminal emulator support by adding a Terminator-specific adapter for hiding scrollbars during a console session.

Changes:

• Fixes the rendered “Success Criteria” label in plan string formatting output.
• Refactors GNOME Terminal gsettings helper into GnomeTerminalAdapter and adds a new TerminatorTerminalAdapter that switches profiles via remotinator.
• Extends TerminalSessionConfig and default adapter list to include Terminator behavior.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File	Description
src/vulcanai/core/plan_types.py	Corrects the printed “Success Criteria” label in plan visualization output.
src/vulcanai/console/terminal_session.py	Adds Terminator support (profile switching + config manipulation) and updates session defaults/adapters.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The inline comment still contains a typo: "Succes Criteria" should be "Success Criteria" to match the rendered label and avoid confusing output/log search.

Suggested change

	# Succes Criteria: <node.success_criteria>
	# Success Criteria: <node.success_criteria>

[Copilot]

TerminatorTerminalAdapter.apply() always restores to terminator_profile_base from config, not the profile that was active before switching. This can leave users on the wrong profile after the session. Consider querying the current profile via remotinator (or otherwise capturing the actual active profile) and storing that in the returned state so restore() can reliably revert to the pre-session profile.

[cferreiragonz]

This is True. We restore to the default profile always. If it does not exist we could fail and right now we do not provide any way of modifying TerminalSessionConfig

[Copilot]

_ensure_hidden_profile() can permanently modify the user's Terminator config (e.g., creating a new profile or overwriting an existing profile's scrollbar_position) and there is no restoration/rollback in restore(). This has user-facing operational impact. Consider tracking whether the file/profile was changed and reverting it on session end, or only creating/modifying a uniquely-named VulcanAI profile when it doesn't already exist (without overwriting user-defined profiles).

[cferreiragonz]

We are permanently modifying the configuration profile of the user by adding a new profile. Maybe we should delete it when VulcanAI is closed?

[cferreiragonz]

Why not fusion both for loops into one and just check cls._TOP_LEVEL_SECTION_RE.match(lines[index]) and lines[index].strip() != "[profiles]" before breaking

Suggested change

	profiles_end = len(lines)
	for index in range(profiles_start + 1, len(lines)):
	if cls._TOP_LEVEL_SECTION_RE.match(lines[index]) and lines[index].strip() != "[profiles]":
	profiles_end = index
	break
	profile_headers: list[tuple[str, int, str]] = []
	for index in range(profiles_start + 1, profiles_end):
	header_match = cls._PROFILE_HEADER_RE.match(lines[index].rstrip("\r\n"))
	if header_match:
	profile_headers.append((header_match.group(2).strip(), index, header_match.group(1)))
	profiles_end = len(lines)
	profile_headers: list[tuple[str, int, str]] = []
	for index in range(profiles_start + 1, len(lines)):
	if cls._TOP_LEVEL_SECTION_RE.match(lines[index]) and lines[index].strip() != "[profiles]":
	profiles_end = index
	break
	header_match = cls._PROFILE_HEADER_RE.match(lines[index].rstrip("\r\n"))
	if header_match:
	profile_headers.append((header_match.group(2).strip(), index, header_match.group(1)))

[Danipiza]

Yeah I had it separated for a cleaner logic. But this is more efficient.