Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR targets Docker-related console usability issues by preventing Hugging Face progress bars from polluting redirected Textual output and by forcing a consistent truecolor/white-text terminal style inside the container.
Changes:
- Pass the console logger into
SBERTEmbedderso embedding initialization can log via the app’s logging sink. - Disable Hugging Face hub progress bars and add a one-time informational log when the SBERT model loads/downloads.
- Force Textual truecolor output and adjust console CSS colors for improved readability in Docker terminals.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/vulcanai/tools/tool_registry.py |
Wires the registry logger into the default SBERT embedder to route messages through the console sink. |
src/vulcanai/tools/embedder.py |
Adds HF progress-bar suppression and one-time “model loading” console logging during SBERTEmbedder init. |
src/vulcanai/console/console.py |
Forces truecolor behavior and applies explicit white text styling in the Textual UI. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
cferreiragonz
requested changes
Mar 4, 2026
e88bccb to
04e227d
Compare
Signed-off-by: danipiza <dpizarrogallego@gmail.com>
…rror Signed-off-by: danipiza <dpizarrogallego@gmail.com>
Signed-off-by: danipiza <dpizarrogallego@gmail.com>
Signed-off-by: danipiza <dpizarrogallego@gmail.com>
cferreiragonz
approved these changes
Mar 5, 2026
Contributor
cferreiragonz
left a comment
There was a problem hiding this comment.
LGTM with green CI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes:
The
gnomeadapter (interminal_session.pyfrom the PR Fix host terminal) can not change the terminal settings from inside the container becausegsettings/dconfneeds the HOSTgnomesessionDBusanddconf backend. In a normal terminal run, the scrollbar in agnometerminal is hidden, but it is no possible inside a docker container.Before (Terminator)
Before (GNOME)
After