Skip to content

[#24213] Docker fixes#16

Merged
cferreiragonz merged 4 commits intomainfrom
fix/docker
Mar 5, 2026
Merged

[#24213] Docker fixes#16
cferreiragonz merged 4 commits intomainfrom
fix/docker

Conversation

@Danipiza
Copy link
Contributor

@Danipiza Danipiza commented Feb 26, 2026

Description

This PR fixes:

  • Docker logger sink
os.environ.setdefault("HF_HUB_DISABLE_PROGRESS_BARS", "1")

# Print info message for loading/downloading hugging face model
def info_msg_hf_model_loading(...):
    ...
  • Docker terminal style
os.environ.setdefault("COLORTERM", "truecolor")
textual_constants.COLOR_SYSTEM = "truecolor"

The gnome adapter (in terminal_session.py from the PR Fix host terminal) can not change the terminal settings from inside the container because gsettings/dconf needs the HOST gnome session DBus and dconf backend. In a normal terminal run, the scrollbar in a gnome terminal is hidden, but it is no possible inside a docker container.

Before (Terminator)

Screenshot from 2026-02-25 16-15-44

Before (GNOME)

Screenshot from 2026-02-25 16-17-46

After

Screenshot from 2026-02-25 16-15-57

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR targets Docker-related console usability issues by preventing Hugging Face progress bars from polluting redirected Textual output and by forcing a consistent truecolor/white-text terminal style inside the container.

Changes:

  • Pass the console logger into SBERTEmbedder so embedding initialization can log via the app’s logging sink.
  • Disable Hugging Face hub progress bars and add a one-time informational log when the SBERT model loads/downloads.
  • Force Textual truecolor output and adjust console CSS colors for improved readability in Docker terminals.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
src/vulcanai/tools/tool_registry.py Wires the registry logger into the default SBERT embedder to route messages through the console sink.
src/vulcanai/tools/embedder.py Adds HF progress-bar suppression and one-time “model loading” console logging during SBERTEmbedder init.
src/vulcanai/console/console.py Forces truecolor behavior and applies explicit white text styling in the Textual UI.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

@cferreiragonz cferreiragonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small NITs. Remember to rebase too

@Danipiza Danipiza force-pushed the fix/docker branch 2 times, most recently from e88bccb to 04e227d Compare March 5, 2026 09:48
Danipiza added 3 commits March 5, 2026 11:14
Signed-off-by: danipiza <dpizarrogallego@gmail.com>
…rror

Signed-off-by: danipiza <dpizarrogallego@gmail.com>
Signed-off-by: danipiza <dpizarrogallego@gmail.com>
Signed-off-by: danipiza <dpizarrogallego@gmail.com>
@cferreiragonz cferreiragonz requested review from cferreiragonz and removed request for cferreiragonz March 5, 2026 10:25
Copy link
Contributor

@cferreiragonz cferreiragonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@cferreiragonz cferreiragonz merged commit 4053da9 into main Mar 5, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants