[24365] Revert ABI extension to protect UBSan error#6420
Merged
Conversation
Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com>
This reverts commit ff298bdf63e574e20435485a1c21b4828ea839e0. Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com>
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
PR #6386 introduced an ABI extension to solve an UBSan issue with the
statistics::dds::DomainParticipant. This PR reverts that change in order to prevent any ABI modification. To avoid UBSan errors, tests relying on thenarrowoperation of thestatistics::dds::DomainParticipantwill be compiled disabling the-vptroption that detects this specific issue.Contributor Checklist
versions.mdfile (if applicable).Reviewer Checklist