Skip to content

[24365] Revert ABI extension to protect UBSan error#6420

Merged
cferreiragonz merged 2 commits into
masterfrom
hotfix_revert_abi_extension
Jun 5, 2026
Merged

[24365] Revert ABI extension to protect UBSan error#6420
cferreiragonz merged 2 commits into
masterfrom
hotfix_revert_abi_extension

Conversation

@cferreiragonz
Copy link
Copy Markdown
Contributor

@cferreiragonz cferreiragonz commented Jun 4, 2026

Description

PR #6386 introduced an ABI extension to solve an UBSan issue with the statistics::dds::DomainParticipant. This PR reverts that change in order to prevent any ABI modification. To avoid UBSan errors, tests relying on the narrow operation of the statistics::dds::DomainParticipant will be compiled disabling the -vptr option that detects this specific issue.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A: Any new/modified methods have been properly documented using Doxygen.
  • N/A: Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • N/A: Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • N/A: Changes are API compatible.
  • N/A: New feature has been added to the versions.md file (if applicable).
  • N/A: New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A: Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com>
This reverts commit ff298bdf63e574e20435485a1c21b4828ea839e0.

Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com>
@cferreiragonz cferreiragonz added this to the v3.6.2 milestone Jun 4, 2026
@cferreiragonz cferreiragonz requested a review from Danipiza June 4, 2026 09:00
@github-actions github-actions Bot added the ci-pending PR which CI is running label Jun 4, 2026
@cferreiragonz
Copy link
Copy Markdown
Contributor Author

I ran locally ABI checker compatibility between this branch and commit 910ac99 (previous commit of #6386) and obtained 100% compatibility

Copy link
Copy Markdown
Contributor

@Danipiza Danipiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cferreiragonz cferreiragonz merged commit dff5a82 into master Jun 5, 2026
29 checks passed
@cferreiragonz cferreiragonz deleted the hotfix_revert_abi_extension branch June 5, 2026 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-pending PR which CI is running

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants