Skip to content

[24015] Remove unused keep_alive logic#6317

Merged
MiguelCompany merged 1 commit intomasterfrom
remove_unusued_ka
Feb 24, 2026
Merged

[24015] Remove unused keep_alive logic#6317
MiguelCompany merged 1 commit intomasterfrom
remove_unusued_ka

Conversation

@cferreiragonz
Copy link
Contributor

@cferreiragonz cferreiragonz commented Feb 20, 2026

Description

This PR removes unused code regarding an unimplemented keep alive feature.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A: Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A: Any new/modified methods have been properly documented using Doxygen.
  • N/A: Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • N/A: Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • N/A: Changes are API compatible.
  • N/A: New feature has been added to the versions.md file (if applicable).
  • N/A: New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A: Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@cferreiragonz cferreiragonz added this to the v3.5.0 milestone Feb 20, 2026
@emiliocuestaf emiliocuestaf self-requested a review February 23, 2026 08:44
Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com>
@emiliocuestaf emiliocuestaf requested review from emiliocuestaf and removed request for emiliocuestaf February 23, 2026 08:47
@github-actions github-actions bot added the ci-pending PR which CI is running label Feb 23, 2026
Copy link
Contributor

@emiliocuestaf emiliocuestaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI.

@mergify
Copy link
Contributor

mergify bot commented Feb 23, 2026

🧪 CI Insights

Here's what we observed from your CI run for 81946cc.

❌ Job Failures

Pipeline Job Health on master Retries 🔍 CI Insights 📄 Logs
Fast DDS MacOS CI mac-ci / fastdds_test () Unknown 0 View View
Fast DDS Ubuntu CI ubuntu-ci / fastdds_test (RelWithDebInfo) Unknown 1 View View
Fast DDS Windows CI windows-ci / fastdds_test (RelWithDebInfo, examples), v143 Unknown 0 View View

@cferreiragonz cferreiragonz added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed ci-pending PR which CI is running labels Feb 24, 2026
@MiguelCompany MiguelCompany merged commit ecf205b into master Feb 24, 2026
29 of 33 checks passed
@MiguelCompany MiguelCompany deleted the remove_unusued_ka branch February 24, 2026 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants