Skip to content

[23079] Generate swig code for interfaces#477

Merged
MiguelCompany merged 17 commits intomasterfrom
feature/23079
May 28, 2025
Merged

[23079] Generate swig code for interfaces#477
MiguelCompany merged 17 commits intomasterfrom
feature/23079

Conversation

@MiguelCompany
Copy link
Member

@MiguelCompany MiguelCompany commented May 20, 2025 •
edited by Mario-DL
Loading

Description

This PR adds code related to RPC interfaces to TypesSwigInterface.stg.
It also fixes the code generated for the RPC server to only block on the reader's data_available status.

This PR depends on:

Contributor Checklist

  • Commit messages follow the project guidelines.
  • N/A: Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A: Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@MiguelCompany MiguelCompany added this to the v4.1.0 milestone May 21, 2025
@MiguelCompany MiguelCompany marked this pull request as ready for review May 21, 2025 08:55
@MiguelCompany MiguelCompany requested a review from richiware May 21, 2025 08:55
@github-actions github-actions bot added the ci-pending PR which CI is running label May 21, 2025
@MiguelCompany MiguelCompany force-pushed the feature/23079 branch 2 times, most recently from d809429 to e22eb8e Compare May 27, 2025 09:34
@MiguelCompany MiguelCompany requested review from richiware and removed request for richiware May 27, 2025 09:48
@MiguelCompany
Refs #23079. Add interfaces code to TypesSwigInterface.stg
9ed558b 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany
Refs #23079. Swig code for operation return types.
5571482 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany
Refs #23079. Improvements on RpcClientReader.
1102f78 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany
Refs #23079. Avoid duplicates of code generated for template classes.
f29b791 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany
Refs #23079. Generate code for input feeds.
35b4e77 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany
Refs #23079. Generate code to catch exceptions.
3502692 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany
Refs #23079. Director feature for ServerImplementation classes.
b9fae4a 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany
Refs #23079. Avoid Server code for nested interfaces.
81e2ae5 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany
Refs #23079. Server code for feeds.
4e74c0f 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany
Refs #23079. Refactor output arguments.
f309e9c 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany
Refs #23079. Enable thread support for directors and release lock in …
cd6ef51 
…server run().

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany
Refs #23232. Avoid generating detail namespace for interfaces without…
4a345c1 
… output arguments.

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany MiguelCompany requested review from richiware and removed request for richiware May 27, 2025 11:04
Mario-DL added 2 commits May 28, 2025 05:53
@Mario-DL
Windows compilation Fix
939342b 
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
@Mario-DL
MacOs warning Fix
d4b6219 
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
@Mario-DL Mario-DL requested review from richiware and removed request for richiware May 28, 2025 05:54
Mario-DL
Mario-DL suggested changes May 28, 2025
View reviewed changes
Copy link
Contributor

@Mario-DL Mario-DL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good effort here, not easy tricks. Leaving just some comments

Mario-DL
Mario-DL reviewed May 28, 2025
View reviewed changes
@MiguelCompany
Refs #23079. Add copyright header to SwigCMake template.
4a1ca47 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany
Refs #23079. Apply review.
8897346 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Mario-DL
Mario-DL previously approved these changes May 28, 2025
View reviewed changes
Copy link
Contributor

@Mario-DL Mario-DL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@MiguelCompany MiguelCompany requested review from richiprosima and removed request for richiprosima May 28, 2025 10:03
@MiguelCompany
Refs #23079. Directors only necessary when there are interfaces.
92af4cd 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany MiguelCompany requested a review from Mario-DL May 28, 2025 10:28
@MiguelCompany MiguelCompany merged commit f051d17 into master May 28, 2025
4 checks passed
@MiguelCompany MiguelCompany deleted the feature/23079 branch May 28, 2025 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Mario-DL Mario-DL Mario-DL approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ci-pending PR which CI is running

Projects

None yet

Milestone

v4.1.0

Development

Successfully merging this pull request may close these issues.

2 participants

@MiguelCompany @Mario-DL