[22850] Fix python code generation for bounded strings by MiguelCompany · Pull Request #440 · eProsima/Fast-DDS-Gen

MiguelCompany · 2025-02-24T15:41:37Z

Description

This PR introduces the following improvements on the code generated for SWIG interfaces:

A setter for fixed_string members receiving a standard string is added.
A %template for each fixed_string member is generated.

This allows setting bounded string members with either of the following alternatives:

struct_name.member_name("string value")

fixed_str = fixed_string_16("string value")
struct_name.member_name(fixed_str)

@Mergifyio backport 4.0.x

Contributor Checklist

Commit messages follow the project guidelines.
Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
- See [22851] Add support for bounded strings Fast-DDS-python#209 for the added tests
N/A: New feature has been documented/Current behavior is correctly described in the documentation.
Applicable backports have been included in the description.

Reviewer Checklist

The PR has a milestone assigned.
The title and description correctly express the PR's purpose.
Check contributor checklist is correct.
Check CI results: changes do not issue any warning.
Check CI results: failing tests are unrelated with the changes.

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

src/main/java/com/eprosima/fastcdr/idl/templates/TypesSwigInterface.stg

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

MiguelCompany · 2025-02-25T11:08:18Z

@Mergifyio backport 4.0.x

mergify · 2025-02-25T11:08:44Z

backport 4.0.x

✅ Backports have been created

Details

#442 [22850] Fix python code generation for bounded strings (backport #440) has been created for branch 4.0.x

* Refs #22835. SWIG extend to set fixed_string from std::string. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #22835. SWIG export template for fixed_string members. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #22835. Fix access to typecode. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #22835. Fix max size typo. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #22835. Fix exported template name. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #22835. Fix extend code. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #22850. Apply suggestions from review. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> --------- Signed-off-by: Miguel Company <miguelcompany@eprosima.com> (cherry picked from commit 8eaca9a)

* Refs #22835. SWIG extend to set fixed_string from std::string. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #22835. SWIG export template for fixed_string members. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #22835. Fix access to typecode. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #22835. Fix max size typo. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #22835. Fix exported template name. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #22835. Fix extend code. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #22850. Apply suggestions from review. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> --------- Signed-off-by: Miguel Company <miguelcompany@eprosima.com> (cherry picked from commit 8eaca9a) Co-authored-by: Miguel Company <miguelcompany@eprosima.com>

MiguelCompany · 2025-02-26T09:42:21Z

@Mergifyio backport 3.3.x

mergify · 2025-02-26T09:42:25Z

backport 3.3.x

✅ Backports have been created

Details

#443 [22850] Fix python code generation for bounded strings (backport #440) has been created for branch 3.3.x but encountered conflicts

* Refs #22835. SWIG extend to set fixed_string from std::string. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #22835. SWIG export template for fixed_string members. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #22835. Fix access to typecode. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #22835. Fix max size typo. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #22835. Fix exported template name. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #22835. Fix extend code. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #22850. Apply suggestions from review. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> --------- Signed-off-by: Miguel Company <miguelcompany@eprosima.com> (cherry picked from commit 8eaca9a) # Conflicts: # src/main/java/com/eprosima/fastcdr/idl/templates/TypesSwigInterface.stg

* Fix python code generation for bounded strings (#440) * Refs #22835. SWIG extend to set fixed_string from std::string. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #22835. SWIG export template for fixed_string members. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #22835. Fix access to typecode. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #22835. Fix max size typo. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #22835. Fix exported template name. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #22835. Fix extend code. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #22850. Apply suggestions from review. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> --------- Signed-off-by: Miguel Company <miguelcompany@eprosima.com> (cherry picked from commit 8eaca9a) # Conflicts: # src/main/java/com/eprosima/fastcdr/idl/templates/TypesSwigInterface.stg * Fix conflicts Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Conditional build of fastcdr v2 features Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Always import optional header Signed-off-by: Miguel Company <miguelcompany@eprosima.com> --------- Signed-off-by: Miguel Company <miguelcompany@eprosima.com> Co-authored-by: Miguel Company <miguelcompany@eprosima.com>

MiguelCompany added 6 commits February 24, 2025 15:51

Refs #22835. SWIG extend to set fixed_string from std::string.

29ea6d3

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

Refs #22835. SWIG export template for fixed_string members.

a7abde1

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

Refs #22835. Fix access to typecode.

39b5b96

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

Refs #22835. Fix max size typo.

f3ad4f8

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

Refs #22835. Fix exported template name.

7422704

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

Refs #22835. Fix extend code.

2f7395b

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

MiguelCompany added this to the v4.1.0 milestone Feb 24, 2025

MiguelCompany mentioned this pull request Feb 24, 2025

[22851] Add support for bounded strings eProsima/Fast-DDS-python#209

Merged

9 tasks

richiware requested changes Feb 25, 2025

View reviewed changes

src/main/java/com/eprosima/fastcdr/idl/templates/TypesSwigInterface.stg Show resolved Hide resolved

Refs #22850. Apply suggestions from review.

36f28c8

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

MiguelCompany requested a review from richiware February 25, 2025 08:04

github-actions bot added ci-pending PR which CI is running labels Feb 25, 2025

richiware approved these changes Feb 25, 2025

View reviewed changes

MiguelCompany merged commit 8eaca9a into master Feb 25, 2025
4 checks passed

MiguelCompany deleted the bugfix/22835 branch February 25, 2025 11:08

mergify bot mentioned this pull request Feb 26, 2025

[22850] Fix python code generation for bounded strings (backport #440) #443

Merged

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[22850] Fix python code generation for bounded strings#440

[22850] Fix python code generation for bounded strings#440
MiguelCompany merged 7 commits intomasterfrom
bugfix/22835

MiguelCompany commented Feb 24, 2025 •

edited by richiware

Loading

Uh oh!

Uh oh!

Uh oh!

MiguelCompany commented Feb 25, 2025

Uh oh!

mergify bot commented Feb 25, 2025 •

edited

Loading

Uh oh!

MiguelCompany commented Feb 26, 2025

Uh oh!

mergify bot commented Feb 26, 2025 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

MiguelCompany commented Feb 24, 2025 • edited by richiware Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Contributor Checklist

Reviewer Checklist

Uh oh!

Uh oh!

Uh oh!

MiguelCompany commented Feb 25, 2025

Uh oh!

mergify bot commented Feb 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Backports have been created

Uh oh!

MiguelCompany commented Feb 26, 2025

Uh oh!

mergify bot commented Feb 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Backports have been created

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

MiguelCompany commented Feb 24, 2025 •

edited by richiware

Loading

mergify bot commented Feb 25, 2025 •

edited

Loading

mergify bot commented Feb 26, 2025 •

edited

Loading