Add ability to resolve/reject and hide#99
Open
adrhumphreys wants to merge 3 commits intoeBay:mainfrom
Open
Conversation
Codecov Report
@@ Coverage Diff @@
## main #99 +/- ##
===========================================
- Coverage 100.00% 97.12% -2.88%
===========================================
Files 1 1
Lines 201 209 +8
Branches 30 30
===========================================
+ Hits 201 203 +2
- Misses 0 6 +6
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Collaborator
|
Hi @adrhumphreys , thanks for the PR! It looks good to me. Could you please also add unit tests for the new APIs so that it would be merged? |
Author
|
Hey @supnate sorry for the long delay, just added in some tests now if you want to have a review over them, thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey team,
Loving the library and I found that I often would call resolve and hide or reject and hide, and noticed that there was a similar pattern mentioned in #88
This would mean that users are able to do something like:
Happy to update with any feedback
Reason for creating new methods was to keep backwards compatibility