Fix for nullable transformers on nullable array item object properties.

NST/src/main/java/com/ebay/openapi/export/jsonschema/EbaySchemaTransformer.java

@@ -78,15 +78,15 @@ public abstract class EbaySchemaTransformer {
     static void applyToChildSchemas(final JsonNode schemaObject, final Consumer<JsonNode> consumer) {
         if (isArrayDefinition(schemaObject)) {
             consumer.accept(itemsDefinition(schemaObject));
-            return;
+        } else {
+            properties(schemaObject).forEachRemaining(consumer);
+            allOf(schemaObject).forEachRemaining(consumer);
+            anyOf(schemaObject).forEachRemaining(consumer);
+            oneOf(schemaObject).forEachRemaining(consumer);
+            schemaComponents(schemaObject).forEachRemaining(consumer);
+            additionalProperties(schemaObject).forEachRemaining(consumer);
         }
-        properties(schemaObject).forEachRemaining(consumer);
-        allOf(schemaObject).forEachRemaining(consumer);
-        anyOf(schemaObject).forEachRemaining(consumer);
-        oneOf(schemaObject).forEachRemaining(consumer);
-        schemaComponents(schemaObject).forEachRemaining(consumer);
         definitions(schemaObject).forEachRemaining(consumer);
-        additionalProperties(schemaObject).forEachRemaining(consumer);
     }
 
     protected static boolean hasAllOfField(final JsonNode n) {

NST/src/main/java/com/ebay/openapi/export/jsonschema/OpenApiToJsonSchema.java

@@ -188,8 +188,8 @@ public void convert() {
 				throw new IllegalStateException(String.format("Status code [%s] is not present for request method [%s] and path [%s] in file: %s", statusCode, requestMethod, requestPath, openApiSpecFilePath));
 			}
 
-		//added below check to fix NPE
-		       if(response.getContent() != null) {
+			//added below check to fix NPE
+			if(response.getContent() != null) {
 				MediaType mediaType = response.getContent().get(MEDIA_TYPE);
 				if (mediaType == null) {
 					throw new IllegalStateException(

NST/src/test/java/com/ebay/nst/schema/validation/OpenApiSchemaValidatorTest.java

@@ -109,4 +109,28 @@ public void schemaValidatePassNullableArrayItem() throws Exception {
 
         validator.validate(testResponsePayload);
     }
+
+    @Test
+    public void schemaValidateNullableProperties() throws Exception {
+
+        OpenApiSchemaValidator validator = new OpenApiSchemaValidator.Builder("/com/ebay/nst/schema/validation/OpenApiSchemaValidatorTest/schema/nullableProperties.yaml", "/test", NstRequestType.GET)
+                .allowAdditionalProperties(OpenApiSchemaValidator.AllowAdditionalProperties.NO)
+                .build();
+
+        String testResponsePayload = ResourceParser.readInResourceFile("/com/ebay/nst/schema/validation/OpenApiSchemaValidatorTest/json/validResponseNullableProperties.json");
+
+        validator.validate(testResponsePayload);
+    }
+
+    @Test
+    public void schemaValidateNullablePropertiesWithValues() throws Exception {
+
+        OpenApiSchemaValidator validator = new OpenApiSchemaValidator.Builder("/com/ebay/nst/schema/validation/OpenApiSchemaValidatorTest/schema/nullableProperties.yaml", "/test", NstRequestType.GET)
+                .allowAdditionalProperties(OpenApiSchemaValidator.AllowAdditionalProperties.NO)
+                .build();
+
+        String testResponsePayload = ResourceParser.readInResourceFile("/com/ebay/nst/schema/validation/OpenApiSchemaValidatorTest/json/validResponseNullablePropertiesWithValues.json");
+
+        validator.validate(testResponsePayload);
+    }
 }

NST/src/test/resources/com/ebay/nst/schema/validation/OpenApiSchemaValidatorTest/json/validResponseNullableProperties.json

@@ -0,0 +1,9 @@
+[
+  {
+    "rank": null,
+    "price": 1,
+    "name": null,
+    "rate": null,
+    "url": null
+  }
+]

NST/src/test/resources/com/ebay/nst/schema/validation/OpenApiSchemaValidatorTest/json/validResponseNullablePropertiesWithValues.json

@@ -0,0 +1,9 @@
+[
+  {
+    "rank": 1,
+    "price": 1,
+    "name": "bob",
+    "rate": 2,
+    "url": "https://www.ebay.com"
+  }
+]

NST/src/test/resources/com/ebay/nst/schema/validation/OpenApiSchemaValidatorTest/schema/nullableProperties.yaml

@@ -0,0 +1,49 @@
+openapi: 3.0.0
+info:
+  title: Type Definitions
+  description: >-
+    Type Definitions
+  version: 1.0.0
+servers:
+  - url: 'http://ebay.com'
+    description: QATE
+paths:
+  /test:
+    get:
+      summary: placeholder summary
+      responses:
+        '200':
+          description: Success
+          content:
+            application/json:
+              schema:
+                $ref: '#/components/schemas/NullablePropertyResponse'
+components:
+  schemas:
+    NullablePropertyResponse:
+      type: array
+      items:
+        $ref: '#/components/schemas/NullablePropertyObject'
+    NullablePropertyObject:
+      type: object
+      additionalProperties: true
+      required:
+        - rank
+        - price
+      properties:
+        rank:
+          type: integer
+          nullable: true
+        price:
+          type: number
+          minimum: 0
+        name:
+          type: string
+          nullable: true
+        rate:
+          type: number
+          nullable: true
+        url:
+          type: string
+          format: uri
+          nullable: true

NSTTutorials/pom.xml

@@ -41,7 +41,7 @@
         <maven.compiler.plugin.version>3.6.0</maven.compiler.plugin.version>
         <maven.surefire.plugin.version>2.9</maven.surefire.plugin.version>
         <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
-        <nstest.version>1.3.1</nstest.version>
+        <nstest.version>1.3.6</nstest.version>
         <nsttutorials.version>0.0.1-SNAPSHOT</nsttutorials.version>
         <testng.version>7.5</testng.version>
         <maven.deploy.skip>true</maven.deploy.skip>

pom.xml

@@ -24,7 +24,7 @@
 		<maven.compiler.plugin.version>3.6.0</maven.compiler.plugin.version>
 		<maven.surefire.plugin.version>2.9</maven.surefire.plugin.version>
 		<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
-		<nstest.version>1.3.5</nstest.version>
+		<nstest.version>1.3.6</nstest.version>
 		<testng.version>7.5</testng.version>
 		<maven.deploy.skip>true</maven.deploy.skip>
 	</properties>