chore: include tag in snapshot ID response#1926
Merged
Conversation
Return snapshot IDs with the tag suffix (e.g. "name:default") and prefer namespace/alias over raw template ID when a name was provided. Update the list endpoint query to fetch the tag from env_build_assignments and adjust integration tests to account for the new composite ID format.
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
tests/integration/internal/tests/api/sandboxes/snapshot_template_test.go
Show resolved
Hide resolved
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a999edba2f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Prioritize namespaced aliases (namespace/alias) over plain aliases so Names[0] returns the most qualified identifier in the API response.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Return snapshot IDs with the tag suffix (e.g. "name:default") and prefer namespace/alias over raw template ID when a name was provided. Update the list endpoint query to fetch the tag from env_build_assignments and adjust integration tests to account for the new composite ID format.
Note
Medium Risk
Changes a public API response identifier format, which may break clients that assume
snapshotIDis a raw template ID or tagless. Query changes are straightforward but touch pagination/listing and identifier parsing paths.Overview
Updates snapshot template create/list responses so
snapshotIDincludes the tag suffix and prefersnamespace/alias:tagwhen a name exists, while keepingnamestagless; the list query now fetches the build tag and enforces deterministic alias ordering, template tag lookups accept tag-suffixed references, and integration tests are adjusted to validate and consume the new composite ID format.Written by Cursor Bugbot for commit d0858ea. This will update automatically on new commits. Configure here.