Conversation
…el uffd handling to a subpackage
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Member
Author
|
It is failing on integration test, because they are not using the custom FC. |
ValentaTomas
changed the title
/proc/PID/mem to access sandbox memory/proc/PID/mem to access sandbox memory; Add Dirty pages via WP
ValentaTomas
changed the title
/proc/PID/mem to access sandbox memory; Add Dirty pages via WP/proc/PID/mem to access sandbox memory; Track dirty pages via WP
| } | ||
|
|
||
| if err != nil { | ||
| return n, fmt.Errorf("failed to read from /proc/%d/mem: %w", v.procMem.Name(), err) |
There was a problem hiding this comment.
Bug: Wrong format specifier for string in error message
The error message uses %d format specifier with v.procMem.Name(), which returns a string (the file path like /proc/PID/mem). The %d verb expects an integer. This will produce a malformed error message with %!d(string=...) instead of the intended file path. The format specifier should likely be %s.
ValentaTomas
changed the title
/proc/PID/mem to access sandbox memory; Track dirty pages via WP
Member
Author
|
Extracted to #1643 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NoopMemoryor implement more general memory mapping lookupNote
Switches memory diffing to read via /proc/PID/mem using Firecracker-provided mappings and tracks dirty pages via UFFD write-protect, while upgrading to FC API 1.10.1 and removing temporary memfile usage.
/proc/PID/memusing FCinstanceInfo.memory_regions; remove temp memfile usage and related env/Makefile wiring.MemoryBackendtoDirty(ctx)(replacesDisable); update sandbox pause/shutdown flows to useDirtyand new memory view for diffs.mem_file_path.Mapping,View) to translate offsets<->host virtual addresses and read process memory; extensive tests added.v1.10.1; addmemory_regionstoInstanceInfo; makemem_file_pathoptional in snapshot create; regenerate models.MAX_PARALLEL_MEMFILE_SNAPSHOTTINGusage; deleteTemporaryMemfileimplementation; clean related action/Makefile envs.Written by Cursor Bugbot for commit 8d94828. This will update automatically on new commits. Configure here.