Add sandbox lifecycle create option#1404
Conversation
🦋 Changeset detectedLatest commit: 9d97411 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
PR SummaryLow Risk Overview Reviewed by Cursor Bugbot for commit 9d97411. Bugbot is set up for automated code reviews on this repo. Configure here. |
Package ArtifactsBuilt from 4f34a40. Download artifacts from this workflow run. JS SDK ( npm install ./e2b-2.28.3-cli-create-lifecycle-json.0.tgzCLI ( npm install ./e2b-cli-2.11.1-cli-create-lifecycle-json.0.tgzPython SDK ( pip install ./e2b-2.27.1+cli.create.lifecycle.json-py3-none-any.whl |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: caae7c5dad
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
caae7c5 to
8bb1920
Compare
mishushakov
left a comment
There was a problem hiding this comment.
would change DX here by flattening the params, that should also help with parsing.
if you want them under lifecycle anyways, you could also:
e2b sbx create base --lifecycle.autoresume --lifecycle.ontimeout="pause"
| .option( | ||
| '--lifecycle <json>', | ||
| 'sandbox lifecycle JSON, eg. {"onTimeout":"pause","autoResume":true}', | ||
| parseLifecycle | ||
| ) |
There was a problem hiding this comment.
I would flatten this to --ontimeout and --autoresume
There was a problem hiding this comment.
kk, fixed
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 09d5b1b. Configure here.
09d5b1b to
c994bb5
Compare
c994bb5 to
9d97411
Compare

adds the lifecycle for autoresume/autopause and timeout to the cli