-
Notifications
You must be signed in to change notification settings - Fork 925
feat(sdk): retry transient network errors and rate limits #1378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
jakubno
wants to merge
11
commits into
main
Choose a base branch
from
feat/retry-transient-errors
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
a93c500
feat(sdk): retry transient network errors and rate limits
jakubno f45e99b
fix(sdk): lower retry backoff base to 100ms
jakubno 330a96d
fix(python-sdk): propagate retries through get_api_params
jakubno 042ac36
fix(sdk): address retry PR review comments
jakubno ef160b9
fix(sdk): prevent retry hang on large bodies; unify retry guard
jakubno 94daff5
refactor(js-sdk): make utils.wait abort-aware and reuse it in retry
jakubno f96449a
fix(python-sdk): bound retry total time by request timeout; don't rep…
jakubno c40b28b
fix(python-sdk): reject non-integer retries to match JS validation
jakubno 0b21b16
fix(python-sdk): retry envd unary RPC on rejected transient failures
jakubno df035e9
Merge branch 'main' into feat/retry-transient-errors
jakubno 9bb851f
fix(python-sdk): cap envd RPC Retry-After to match e2b._retry
jakubno File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| 'e2b': minor | ||
| --- | ||
|
|
||
| feat(js-sdk): automatically retry requests on transient failures. The SDK now retries on connection errors and `429`/`502`/`503`/`504` responses using exponential backoff with jitter, and honors a server-provided `Retry-After` header (so rate limiting is handled transparently). Idempotent requests are retried on any transient failure; non-idempotent requests (e.g. `Sandbox.create`) are only retried when the server provably did not process them (e.g. throttling). Configure via the new `retries` option (or `E2B_MAX_RETRIES` env var); set `retries: 0` to disable. Defaults to `3` retries. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| '@e2b/python-sdk': minor | ||
| --- | ||
|
|
||
| feat(python-sdk): automatically retry requests on transient failures. The SDK now retries on connection errors and `429`/`502`/`503`/`504` responses using exponential backoff with jitter, and honors a server-provided `Retry-After` header (so rate limiting is handled transparently). Idempotent requests are retried on any transient failure; non-idempotent requests (e.g. `Sandbox.create`) are only retried when the server provably did not process them (e.g. throttling). The envd RPC retry now also uses backoff between attempts. Configure via the new `retries` option (or `E2B_MAX_RETRIES` env var); set `retries=0` to disable. Defaults to `3` retries. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merge python changeset into it