Skip to content

fix(js-sdk): return from iterateEvents on end instead of break #1157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
beran-t wants to merge 1 commit into
base: main
Choose a base branch
from
+15 −2
Open

fix(js-sdk): return from iterateEvents on end instead of break #1157

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions packages/js-sdk/src/sandbox/commands/commandHandle.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,8 @@ export class CommandHandle
stdout: this.stdout,
stderr: this.stderr,
}
break
this.handleDisconnect()
return
}
// TODO: Handle empty events like in python SDK
}
Expand All @@ -234,7 +235,19 @@ export class CommandHandle
}
}
} catch (e) {
this.iterationError = handleRpcError(e)
if (!this.result) {
this.iterationError = handleRpcError(e)
}
}
// Trigger connectrpc's deadline timer cleanup by forcing one more
// .next() call on the events stream. On platforms where abort propagates
// to the body reader (Deno), this rejects and clears the timer via
// connectrpc's abort() callback. On platforms where it doesn't (Node.js
// per nodejs/undici#1940), this settles when the server closes the stream.
if (this.result) {
this.events[Symbol.asyncIterator]()
.next()
.catch(() => {})
}
}
}
Loading