Meta feature: add devcontainer support for standardization (Fedora Linux fails when running tests)#1075
Open
digitr4ce wants to merge 1 commit intoe2b-dev:mainfrom
Open
Conversation
|
Author
|
I have some errands to run, but will look into the changeset once I get back home. |
Author
|
Read through it - I don't think this change would entail a version bump. This is not customer-facing, it's just a development nice-to-have. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Running tests in
js-sdkin a Fedora Linux distribution fails, because Playwright does not have official support for Linux distributions outside of Debian / Ubuntu based distros.Details
Ran into the issue while running the tests for a change I was trying to do regarding bug #1055. I was trying to fix it to get a feel for the repository and code structure.
Fix
Add a
.devcontainerfolder with a configuration file for VSCode and a generic Dockerfile. This allows for development in an isolated container based on Ubuntu, no matter the Linux distribution.This should allow Linux users to more freely contribute to the project.