Throw when copying from paths outside the context dir by mishushakov · Pull Request #1067 · e2b-dev/E2B

mishushakov · 2026-01-08T13:01:49Z

Note

Medium Risk
Introduces stricter validation and path normalization for copy inputs, which can break existing templates that relied on absolute paths or .. traversal; otherwise changes are localized and well-covered by tests.

Overview
Prevents path traversal in template copy operations by throwing when the source path is outside the template context directory (absolute paths, .. escapes), while preserving stack traces for better error attribution.

Adds cross-platform path normalization (normalizePath/normalize_path) and a shared safety check (isSafeRelative/is_safe_relative) in both the JS and Python SDKs, and updates CLI fixtures and Dockerfile parsing/tests to reflect normalized destinations (e.g., removing trailing slashes) plus new unit coverage for the helpers.

^{Written by Cursor Bugbot for commit bd60304. This will update automatically on new commits. Configure here.}

changeset-bot · 2026-01-08T13:01:54Z

🦋 Changeset detected

Latest commit: bd60304

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
@e2b/python-sdk	Patch
e2b	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: da296034db

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

packages/js-sdk/src/template/index.ts

packages/python-sdk/e2b/template/main.py

packages/python-sdk/tests/async/template_async/test_stacktrace.py

packages/js-sdk/src/template/utils.ts

jakubno

why can't we throw directly in .copy() command? Can't you resolve the path directly there? You want to work with the relative path ideally everywhere anyway?

packages/python-sdk/e2b/template/utils.py

packages/js-sdk/src/template/utils.ts

packages/python-sdk/e2b/template/utils.py

packages/python-sdk/tests/shared/template/utils/test_is_safe_relative.py

mishushakov · 2026-01-14T11:58:42Z

Cursor review

cursor

✅ Bugbot reviewed your changes and found no bugs!

jakubno · 2026-01-22T06:41:28Z

packages/js-sdk/src/template/index.ts


    for (const src of srcs) {
+      const normalizedSrc = normalizePath(src.toString())
+      const normalizedDest = normalizePath(dest.toString())


You can move this outside of the for loop

jakubno · 2026-01-22T06:43:35Z

packages/js-sdk/tests/template/utils/isSafeRelative.test.ts

+      expect(isSafeRelative('../file.txt')).toBe(false)
+    })
+
+    test('should return true for paths starting with ..\\', () => {


Suggested change

test('should return true for paths starting with ..\\', () => {

test('should return false for paths starting with ..\\', () => {

jakubno · 2026-01-22T06:43:51Z

packages/js-sdk/tests/template/utils/isSafeRelative.test.ts

+      expect(isSafeRelative('..\\file.txt')).toBe(false)
+    })
+
+    test('should return true for normalized paths that escape context', () => {


Suggested change

test('should return true for normalized paths that escape context', () => {

test('should return false for normalized paths that escape context', () => {

jakubno · 2026-01-22T06:44:03Z

packages/js-sdk/tests/template/utils/isSafeRelative.test.ts

+      expect(isSafeRelative('..')).toBe(false)
+    })
+
+    test('should return true for paths starting with ../', () => {


Suggested change

test('should return true for paths starting with ../', () => {

test('should return false for paths starting with ../', () => {

jakubno · 2026-01-22T06:44:59Z

packages/js-sdk/tests/template/utils/isSafeRelative.test.ts

+      expect(isSafeRelative('./folder/file.txt')).toBe(true)
+    })
+
+    test('should return false for glob patterns', () => {


Suggested change

test('should return false for glob patterns', () => {

test('should return true for glob patterns', () => {

jakubno · 2026-01-29T09:58:53Z

packages/python-sdk/e2b/template/utils.py

+    # Determine if absolute
+    is_absolute = working_path.startswith("/") or working_path.startswith("\\")
+
+    # Normalize separators to '/'
+    normalized_path = re.sub(r"[\\/]+", "/", working_path)


reverse the order to simplify

jakubno · 2026-01-29T09:59:13Z

packages/python-sdk/e2b/template/utils.py

+
+    for part in parts:
+        if part == "..":
+            if normalized and normalized[-1] != "..":


same issue as in JS with ./..

jakubno · 2026-01-29T09:59:37Z

packages/python-sdk/e2b/template/utils.py

+        os.path.isabs(norm_path)
+        or norm_path == ".."
+        or norm_path.startswith("../")
+        or norm_path.startswith("..\\")


normpath doesn't contain \ anymore right?

jakubno · 2026-01-29T09:59:51Z

packages/python-sdk/tests/async/template_async/methods/test_from_dockerfile.py

    dockerfile = """FROM node:24
-COPY --chown=myuser:mygroup app.js /app/
-COPY --chown=anotheruser config.json /config/"""
+COPY --chown=myuser:mygroup app.js /app


why did you remove the extra slashes?

jakubno · 2026-01-29T10:00:11Z

packages/python-sdk/tests/shared/template/utils/test_normalize_path.py

+from e2b.template.utils import normalize_path
+
+
+class TestBasicPathNormalization:


add a test with ./..

throw when copying from dirs other than context dir

da29603

mishushakov requested review from ValentaTomas and jakubno as code owners January 8, 2026 13:01

chatgpt-codex-connector bot reviewed Jan 8, 2026

View reviewed changes

packages/js-sdk/src/template/index.ts Outdated Show resolved Hide resolved

packages/python-sdk/e2b/template/main.py Outdated Show resolved Hide resolved

added path normalization

49e1d63

vercel bot temporarily deployed to Preview January 8, 2026 13:08 Inactive

cursor bot reviewed Jan 8, 2026

View reviewed changes

packages/python-sdk/tests/async/template_async/test_stacktrace.py Outdated Show resolved Hide resolved

packages/python-sdk/tests/async/template_async/test_stacktrace.py Outdated Show resolved Hide resolved

mishushakov added 2 commits January 8, 2026 14:18

upd

6c56d95

moved path handling to files hash (buld-time)

5187988

vercel bot temporarily deployed to Preview January 8, 2026 13:27 Inactive

remove unused vars

484cbbc

vercel bot temporarily deployed to Preview January 8, 2026 13:28 Inactive

remove unused imports

e02de9c

vercel bot temporarily deployed to Preview January 8, 2026 13:29 Inactive

format

850df11

vercel bot temporarily deployed to Preview January 8, 2026 13:30 Inactive

cursor bot reviewed Jan 8, 2026

View reviewed changes

packages/js-sdk/src/template/utils.ts Outdated Show resolved Hide resolved

added isabs check

a6ea577

vercel bot temporarily deployed to Preview January 8, 2026 13:51 Inactive

mishushakov enabled auto-merge (squash) January 8, 2026 14:18

jakubno reviewed Jan 9, 2026

View reviewed changes

packages/python-sdk/e2b/template/utils.py Outdated Show resolved Hide resolved

mishushakov mentioned this pull request Jan 12, 2026

Template build stuck at file copy #1018

Open

Merge branch 'main' into fix-throw-on-copy-abs-rel-paths

d1e8f00

cursor bot reviewed Jan 12, 2026

View reviewed changes

packages/python-sdk/e2b/template/utils.py Outdated Show resolved Hide resolved

vercel bot had a problem deploying to Preview January 12, 2026 14:12 Failure

moved path checking to .copy

bff918b

vercel bot temporarily deployed to Preview January 12, 2026 18:48 Inactive

normalize path only in is_path_outside_context

040aef9

vercel bot temporarily deployed to Preview January 12, 2026 18:52 Inactive

vercel bot temporarily deployed to Preview January 13, 2026 12:33 Inactive

updated isSafeRelative implementation

51065a7

vercel bot temporarily deployed to Preview January 13, 2026 17:05 Inactive

cursor bot reviewed Jan 13, 2026

View reviewed changes

packages/js-sdk/src/template/utils.ts Show resolved Hide resolved

packages/js-sdk/src/template/utils.ts Show resolved Hide resolved

mishushakov added 2 commits January 13, 2026 20:10

renamed

b141fd0

redo normalizePath function

034dcad

vercel bot temporarily deployed to Preview January 13, 2026 19:11 Inactive

use posix style paths

9ec4481

vercel bot temporarily deployed to Preview January 13, 2026 19:14 Inactive

update tests

5b11999

vercel bot temporarily deployed to Preview January 13, 2026 19:21 Inactive

updated generator test signatures

eada42b

vercel bot temporarily deployed to Preview January 13, 2026 19:25 Inactive

updated tests

356d3ec

vercel bot temporarily deployed to Preview January 13, 2026 19:35 Inactive

cursor bot reviewed Jan 13, 2026

View reviewed changes

packages/python-sdk/e2b/template/utils.py Outdated Show resolved Hide resolved

packages/python-sdk/tests/shared/template/utils/test_is_safe_relative.py Show resolved Hide resolved

renamed

f95ade5

vercel bot temporarily deployed to Preview January 13, 2026 19:50 Inactive

fixes windows gotcha

52417cd

vercel bot temporarily deployed to Preview January 13, 2026 22:13 Inactive

corrected the py path normalize implementation to match JS version

e41ffae

vercel bot temporarily deployed to Preview January 14, 2026 11:36 Inactive

lint

56b668f

vercel bot temporarily deployed to Preview January 14, 2026 11:38 Inactive

cursor bot reviewed Jan 14, 2026

View reviewed changes

jakubno requested changes Jan 29, 2026

View reviewed changes

Merge branch 'main' into fix-throw-on-copy-abs-rel-paths

bd60304

mishushakov marked this pull request as draft January 29, 2026 16:07

auto-merge was automatically disabled January 29, 2026 16:07
Pull request was converted to draft

	test('should return true for paths starting with ..\\', () => {
	test('should return false for paths starting with ..\\', () => {

	test('should return true for normalized paths that escape context', () => {
	test('should return false for normalized paths that escape context', () => {

	test('should return false for glob patterns', () => {
	test('should return true for glob patterns', () => {

		from e2b.template.utils import normalize_path


		class TestBasicPathNormalization:

Conversation

mishushakov commented Jan 8, 2026 • edited by cursor bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented Jan 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jakubno left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mishushakov commented Jan 14, 2026

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

mishushakov commented Jan 8, 2026 •

edited by cursor bot

Loading

changeset-bot bot commented Jan 8, 2026 •

edited

Loading