Skip to content

Conversation

@AlexanderKaran
Copy link
Collaborator

NOTE: Please review this PR first #37 as this one builds on it

When checking install times, we can now measure the size of the node modules

Been messing a lot with the script in the last few prs and left some extra stuff in there that can now be removed

  • Artefact downloads no longer need checks
  • Using JSON directly, no string concatenation
  • Removed a few more redundant checks

@AlexanderKaran AlexanderKaran requested a review from 43081j January 24, 2026 23:53
"coldBuildTimeMs": 2479,
"warmBuildTimeMs": 2422
"warmBuildTimeMs": 2422,
"nodeModulesSize": 0,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

presumably these 0 will then later be updated by the CI run?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

100%

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As soon as we merge it

@AlexanderKaran AlexanderKaran merged commit 9d5f96c into main Jan 25, 2026
1 check passed
@AlexanderKaran AlexanderKaran deleted the node-modules-size branch January 25, 2026 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants