Lan files to use array style#5677
Open
tgtje wants to merge 17 commits into
Open
Conversation
Contributor
Author
|
All proposed and found errors resolved |
Contributor
There was a problem hiding this comment.
@tgtje, the three parse errors from the earlier review are all fixed, and every file passes php -l now. Nice one.
The formatting still doesn't quite match what the rest of the codebase uses for array-style LAN files. Two things to look at:
return[needs a space:return [- Each array entry should be indented by 4 spaces
For comparison, here's what the existing files look like (e.g. e107_plugins/banner/languages/English_global.php):
return [
'LAN_PLUGIN_BANNER_NAME' => "Banners",
'LAN_PLUGIN_BANNER_DESCRIPTION' => "Add advertising banners to your e107 website",
];Also, comment_menu/languages/English.php is missing the space before => ('CM_L1'=> vs 'CM_L1' => in the other files).
I know reformatting 13 files through the web editor is tedious. @kreossino shared a formatting script over on #5676 that might help if you can run PHP locally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Why
last remainging php files in array style
What Changed
define to array
How It Was Tested
fresh git installs with and without locale packs (full array and define mode)->
Backwards Compatibility
No BC impact noticed.
AI Model (Optional)
Checklist