Added support for v2.3.3 wrapper in newforumposts#5346
Open
rica-carv wants to merge 7 commits intoe107inc:masterfrom
Open
Added support for v2.3.3 wrapper in newforumposts#5346rica-carv wants to merge 7 commits intoe107inc:masterfrom
rica-carv wants to merge 7 commits intoe107inc:masterfrom
Conversation
|
Code Climate has analyzed commit 3b45bab and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (80% is the threshold). This pull request will bring the total coverage in the repository to 48.9% (0.0% change). View more on Code Climate. |
241b734 to
4f50dac
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Currently newforumposts_menu only supports wrapping via the $SC_WRAPPER variable. With this, it stills support old shortcode wrapping method ($SC_WRAPPER) but also the new one, via the $NEWFORUMPOSTS_MENU_WRAPPER. The later is more versatile than the old one, since it can wrapp per subtemplate...
Description
Added only a line adding wrapper as current e107 version
How Has This Been Tested?
Tested with E107 v2.3.3 and default theme.
Types of Changes
Checklist