Skip to content

fix: ignore shared AGENTS root in rules check#1958

Draft
ProfTrader wants to merge 1 commit into
dyoshikawa:mainfrom
ProfTrader:codex/rulesync-check-root-owner-forkbase
Draft

fix: ignore shared AGENTS root in rules check#1958
ProfTrader wants to merge 1 commit into
dyoshikawa:mainfrom
ProfTrader:codex/rulesync-check-root-owner-forkbase

Conversation

@ProfTrader

Copy link
Copy Markdown
Contributor

Summary

  • Skip project-root AGENTS.md during rules --check for modular rule targets when non-root rule outputs are present.
  • Keep normal generation unchanged, and keep Codex memory files checked.
  • Add unit and e2e coverage for the shared-root AGENTS.md case.

Fixes #1894

Verification

  • pnpm exec vitest run src/features/rules/rules-processor.test.ts -t "ignore shared root AGENTS.md" --silent=true
  • pnpm exec oxfmt --check src/features/rules/rules-processor.test.ts src/features/rules/rules-processor.ts src/lib/generate.ts src/e2e/e2e-rules.spec.ts
  • pnpm exec oxlint src/features/rules/rules-processor.test.ts src/features/rules/rules-processor.ts src/lib/generate.ts src/e2e/e2e-rules.spec.ts --max-warnings 0
  • pnpm run typecheck

Notes

  • Full src/e2e/e2e-rules.spec.ts is blocked locally on Windows because the e2e helper spawns node_modules/.bin/tsx without the .cmd shim, so every e2e case fails before reaching this change.
  • The full rules-processor.test.ts file currently has an unrelated failure on this branch: should generate copilot global non-root files via round-trip.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

generate --check for codexcli rules fails when another target owns AGENTS.md

1 participant