fix: ignore shared AGENTS root in rules check#1958
Draft
ProfTrader wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AGENTS.mdduring rules--checkfor modular rule targets when non-root rule outputs are present.AGENTS.mdcase.Fixes #1894
Verification
pnpm exec vitest run src/features/rules/rules-processor.test.ts -t "ignore shared root AGENTS.md" --silent=truepnpm exec oxfmt --check src/features/rules/rules-processor.test.ts src/features/rules/rules-processor.ts src/lib/generate.ts src/e2e/e2e-rules.spec.tspnpm exec oxlint src/features/rules/rules-processor.test.ts src/features/rules/rules-processor.ts src/lib/generate.ts src/e2e/e2e-rules.spec.ts --max-warnings 0pnpm run typecheckNotes
src/e2e/e2e-rules.spec.tsis blocked locally on Windows because the e2e helper spawnsnode_modules/.bin/tsxwithout the.cmdshim, so every e2e case fails before reaching this change.rules-processor.test.tsfile currently has an unrelated failure on this branch:should generate copilot global non-root files via round-trip.