test(grokcli): add rules global-mode e2e happy-path case (#1953)#1956
Closed
hernaninverso wants to merge 1 commit into
Closed
test(grokcli): add rules global-mode e2e happy-path case (#1953)#1956hernaninverso wants to merge 1 commit into
hernaninverso wants to merge 1 commit into
Conversation
Follow-up from dyoshikawa#1953 (merged PR dyoshikawa#1909). grokcli registers supportsGlobal: true and the docs advertise the global scope, but the global-mode e2e matrix in e2e-rules.spec.ts only covered project mode. Add the global entry, mirroring the deepagents precedent (also supportsGlobal + folds non-root rules into the single root AGENTS.md). Closes dyoshikawa#1953; also covers the e2e gap noted in dyoshikawa#1917.
Contributor
Author
|
Closing as redundant — I see you already added the same global-mode e2e entry ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #1953 (Finding 1). Adds the missing global-mode happy-path e2e entry for the grokcli rules target in
src/e2e/e2e-rules.spec.ts:grokcli registers
supportsGlobal: trueand the docs advertise the global scope, but the global-mode matrix only covered project mode. This mirrors thedeepagentsprecedent (alsosupportsGlobal+ folds non-root rules into the single rootAGENTS.md), and matches the equivalent grokcli skills fix (#1944) and subagents global coverage (#1950).Finding 2 in #1953 (stale PR description) needs no code change.
Testing
grokclirules e2e cases (project + the new global-mode) pass;pnpm check(oxfmt/oxlint/tsgo) andcicheck:contentare clean.Also closes the e2e gap recorded in #1917.