docs(feature-research/kilo): mirror hooks phrasing for subagents row#1646
docs(feature-research/kilo): mirror hooks phrasing for subagents row#1646Chen17-sq wants to merge 1 commit into
Conversation
Addresses item 3 in dyoshikawa#1616. KiloSubagent is registered in src/features/subagents/subagents-processor.ts, so the previous Upstream-surface cell ("Custom modes/agents; no README-supported Rulesync Kilo subagents target") read as if there is no support at all. Reuse the hedged phrasing already used by the hooks row in the same file: "Adapter exists in source, but no README-supported Rulesync Kilo subagents target". The Official-docs URL is kept unchanged. No other rows touched.
|
Thank you for your contribution! Unfortunately, you currently have 4 open PRs (including this one), which exceeds the limit of 2 for external contributors. Please wait for an existing PR to be reviewed/merged, or close one before opening a new one. See CONTRIBUTING.md for details. |
|
Closing this proactively — the github-actions bot flagged that I'm well over the 2-PR limit for external contributors documented in CONTRIBUTING.md. I opened these nine PRs in one batch without spotting that rule first, which was my mistake — sorry for the noise. The patch in this PR is ready as-is ( Keeping #1643 ( |
|
Reopening — #1644 (toPosixPath copilot-rule refactor) merged 5/20, so I'm back at 1/2 PR limit. This is the smallest of the six remaining closed follow-ups: 1-line phrasing fix to mirror the existing hooks-row sentinel in the same file. Addresses #1616 item 3. Branch unchanged at |
dyoshikawa-claw
left a comment
There was a problem hiding this comment.
The change itself is correct: removing the "Custom modes/agents; " prefix from the subagents description so it reads identically to the hooks row. That's a clean consistency win.
The only issue is the merge conflict. Commit 7dfac8e on main already updated this same line to include the "adapter exists" phrasing (but left the "Custom modes/agents; " prefix in place — that hybrid wording is what your PR addresses). A rebase onto current main should resolve trivially: the PR branch just needs to drop the prefix from main's current version of the line.
| | `mcp` | `https://kilo.ai/docs/automate/mcp/using-in-kilo-code` | `kilo.jsonc`, `.kilo/kilo.jsonc`, global `~/.config/kilo/kilo.jsonc`, MCP tool permissions | | ||
| | `commands` | `https://kilo.ai/docs/customize/custom-modes` | Mode and workflow customization surfaces; Rulesync maps command files | | ||
| | `subagents` | `https://kilo.ai/docs/customize/custom-subagents` | Custom modes/agents; no README-supported Rulesync Kilo subagents target | | ||
| | `subagents` | `https://kilo.ai/docs/customize/custom-subagents` | Adapter exists in source, but no README-supported Rulesync Kilo subagents target | |
There was a problem hiding this comment.
The wording change matches the pattern already established by the hooks row — "Adapter exists in source, but no README-supported Rulesync Kilo ... target". No concerns with the content itself.
dyoshikawa
left a comment
There was a problem hiding this comment.
Thanks for this. The underlying observation is correct and the factual claim checks out — KiloSubagent is wired up in src/features/subagents/subagents-processor.ts and kilo-subagent.ts exists, so "adapter exists in source" is accurate. The issue is that main already moved this line: it now reads "Custom modes/agents; adapter exists in source, but no README-supported Rulesync Kilo subagents target", which already folds in the nuance you're after. The PR is also CONFLICTING against main now. On top of that, this PR's wording drops the "Custom modes/agents;" upstream-surface prefix (see inline), which main keeps for a reason — unlike the hooks row, the subagents row does have an upstream surface. So mirroring hooks exactly loses information here. I'd suggest closing this; the intent is already on main. If you want to keep the branch, rebase and preserve the "Custom modes/agents;" prefix.
| | `mcp` | `https://kilo.ai/docs/automate/mcp/using-in-kilo-code` | `kilo.jsonc`, `.kilo/kilo.jsonc`, global `~/.config/kilo/kilo.jsonc`, MCP tool permissions | | ||
| | `commands` | `https://kilo.ai/docs/customize/custom-modes` | Mode and workflow customization surfaces; Rulesync maps command files | | ||
| | `subagents` | `https://kilo.ai/docs/customize/custom-subagents` | Custom modes/agents; no README-supported Rulesync Kilo subagents target | | ||
| | `subagents` | `https://kilo.ai/docs/customize/custom-subagents` | Adapter exists in source, but no README-supported Rulesync Kilo subagents target | |
There was a problem hiding this comment.
This drops the leading "Custom modes/agents;" prefix that main keeps. The hooks row omits an upstream-surface phrase because it has no dedicated upstream surface ("No dedicated upstream hooks surface in map"), but the subagents row does point at an upstream surface (custom-subagents) realized as custom modes/agents. So aligning the two phrasings verbatim removes meaningful upstream info. Better to keep the prefix.
Summary
Addresses item 3 from #1616.
The
subagentsrow in.rulesync/skills/rulesync-feature-research/references/kilo.mdpreviously read:That phrasing reads as if Rulesync has no support for Kilo subagents at all. In fact,
KiloSubagentis registered insrc/features/subagents/subagents-processor.ts(import { KiloSubagent } …at line 22, registered at line 184) — what's actually true is that the README's "Supported Tools and Features" table does not yet claim the target for Kilo.The
hooksrow on the same file already encodes that exact nuance:This PR reuses that hedged phrasing for the
subagentsrow, so the two parallel cases now read consistently. TheOfficial docsURL is unchanged.Test plan
pnpm cicheck(fmt + oxlint + eslint + tsgo + 5550 vitest + sync-skill-docs check + cspell + secretlint) passes locally on Node 22.pnpm dev generatealso runs cleanly, so the generated mirrors under.claude/,.opencode/,.github/,.takt/regenerate without complaint.Refs #1616 (item 3 of 5 — the other follow-ups in that issue are out of scope here).