Skip to content

Conversation

@bbiiggppiigg
Copy link
Member

No description provided.

@bbiiggppiigg bbiiggppiigg requested a review from hainest January 29, 2025 17:40
@bbiiggppiigg
Copy link
Member Author

The tests pass with the changes made in
dyninst/dyninst#1884

@hainest
Copy link
Contributor

hainest commented Jan 30, 2025

Is this still passing with the latest version of dyninst/dyninst#1884?

@bbiiggppiigg
Copy link
Member Author

@hainest
This test will only pass after dyninst/dyninst#1884
There was a bug where
hw_reg_ib_sts and hw_reg_status share the same baseID, which is fixed in that PR.

https://github.com/dyninst/dyninst/blob/ac803d7af626455abaa3bbd69ea997fd6099a371/common/h/registers/AMDGPU/amdgpu_gfx90a_regs.h#L105

@bbiiggppiigg
Copy link
Member Author

@hainest
So based on my understanding of the workflow file, the CI for this repo will not automatically fetch the latest dyninst master but instead relies on the container to be updated?

@hainest
Copy link
Contributor

hainest commented Jan 30, 2025

Correct. You'll have to wait until https://github.com/dyninst/dyninst/actions/runs/13057617170 finishes.

@bbiiggppiigg bbiiggppiigg merged commit 93cd995 into master Jan 30, 2025
2 checks passed
@bbiiggppiigg bbiiggppiigg deleted the bbiiggppiigg/amd_register_uniqueness branch January 30, 2025 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants