fix(fastapi): invalid utf8 header values are now not breaking trace#114
Open
bwcgn wants to merge 1 commit intodynatrace-oss:masterfrom
Open
fix(fastapi): invalid utf8 header values are now not breaking trace#114bwcgn wants to merge 1 commit intodynatrace-oss:masterfrom
bwcgn wants to merge 1 commit intodynatrace-oss:masterfrom
Conversation
|
Author
|
@dlopes7 Can this be patched? :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Fix: Handle invalid UTF-8 in FastAPI middleware headers
Problem
The FastAPI middleware could crash with a
UnicodeDecodeErrorwhen processing HTTP headers containing invalid UTF-8 byte sequences. This occurred in both request and response header processing where.decode()was called without error handling.Solution
Added
errors='replace'parameter to all.decode()calls for header keys and values. Invalid UTF-8 bytes are now replaced with the Unicode replacement character (�) instead of raising an exception.Changes
.decode('utf-8', errors='replace')Impact