Skip to content

Fix getting Destination schema #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DWDBE merged 1 commit into from
Jan 21, 2025
Merged

Fix getting Destination schema #31

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Dynamicweb.DataIntegration.Providers.ExcelProvider.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<Version>10.6.1</Version>
<Version>10.6.2</Version>
<AssemblyVersion>1.0.0</AssemblyVersion>
<Title>Excel Provider</Title>
<Description>Excel Provider</Description>
Expand Down
8 changes: 4 additions & 4 deletions src/ExcelProvider.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,8 @@ public string DestinationFile

public override Schema GetOriginalDestinationSchema()
{
return schema = new Schema();
schema ??= GetOriginalSourceSchema();
return schema;
}

public override bool SchemaIsEditable => true;
Expand Down Expand Up @@ -310,7 +311,7 @@ private void GetSchemaForTableFromFile(Schema schema, Dictionary<string, ExcelRe

Schema IDestination.GetSchema()
{
schema ??= new Schema();
schema ??= GetOriginalSourceSchema();
return schema;
}

Expand Down Expand Up @@ -377,8 +378,7 @@ public override void OverwriteSourceSchemaToOriginal()
}

public override void OverwriteDestinationSchemaToOriginal()
{
schema = new Schema();
{
}

public override string ValidateDestinationSettings()
Expand Down
Loading