chore(dxlink-core): Include more details to server error#36
Open
antonio-pedro99 wants to merge 2 commits into
Open
chore(dxlink-core): Include more details to server error#36antonio-pedro99 wants to merge 2 commits into
antonio-pedro99 wants to merge 2 commits into
Conversation
d75612f to
000ba0e
Compare
Fyzu
reviewed
Apr 27, 2026
5b3f5ae to
71990e1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves how errors are handled and exposed in the DXLink WebSocket client and core libraries. The main focus is on ensuring that error listeners receive a normalized error object that includes the
channelwhere the error occurred, making error handling more consistent and informative. The changes affect both the implementation and tests, as well as the protocol specification documentation.Error Handling Improvements
DXLinkErrorinterface now includes achannelfield, indicating the channel where the error happened (0for connection-level errors).type,channel, andmessage, ensuring all error listeners receive full error context. [1] [2] [3] [4] [5] [6]Testing Enhancements
index.test.tsto verify that both connection and channel error listeners receive the correct error payload, including thechannelmetadata.Documentation Updates
type,channel, andmessage, and to explain how protocol error frames are routed and exposed.Test and Type Imports
Fixes #31