feat: shell_screenshot returns png_url and svg_url#63
Open
fahd04 wants to merge 1 commit intodwmkerr:mainfrom
Open
feat: shell_screenshot returns png_url and svg_url#63fahd04 wants to merge 1 commit intodwmkerr:mainfrom
fahd04 wants to merge 1 commit intodwmkerr:mainfrom
Conversation
Add png_url and svg_url to shell_screenshot response alongside download_url for backward compatibility. Users can now choose SVG for scalability or PNG for compatibility. Also fix TypeScript error in buffer-to-svg.ts (showCursor not in IModes type) that prevented local build. Closes dwmkerr#45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
png_urlandsvg_urlto theshell_screenshottool response, addressing issue #45.Changes
shell_screenshot now returns both URLs in the response:
{ "filename": "screenshot.png", "download_url": "http://localhost:7498/files/.../screenshot.png", "png_url": "http://localhost:7498/files/.../screenshot.png", "svg_url": "http://localhost:7498/files/.../screenshot.svg", "hint": "Use curl -o <filename> <download_url> to save the file" }Keeps
download_url(pointing to PNG) for backward compatibilityUpdated tool description to mention both formats
Additional fix
buffer-to-svg.ts:showCursoris not in theIModestype definition from @xterm/headless. Added type assertion to unblock local build.Testing
Closes #45