Fix passing touch and release values to the device#2
Open
amir-s wants to merge 1 commit intodwisk:masterfrom
Open
Fix passing touch and release values to the device#2amir-s wants to merge 1 commit intodwisk:masterfrom
amir-s wants to merge 1 commit intodwisk:masterfrom
Conversation
Author
|
Could you please take a look @dwisk? |
amir-s
commented
Jun 8, 2022
|
|
||
| MPR121.prototype.is_touched = function(pin) { | ||
| if (pin < 0 || pin >= 12) { return false; } | ||
| if (pin < 0 || pin >= 12) { return false; } |
Author
There was a problem hiding this comment.
Swapping some invisible characters with an actual space character.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The values are not currently being passed downstream and are hardcoded.