Method lifetimes info #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add input_has_arena and output_has_arena boolean fields - Track whether input/output types require arena lifetime parameter - Enables conditional lifetime generation in service codegen Part of refactor: conditional arena lifetime parameters for gRPC methods
- Use existing messages_with_lifetime HashSet to determine arena needs - Set input_has_arena/output_has_arena when creating Method instances - Checks protobuf type names against tracked messages with lifetimes Part of refactor: conditional arena lifetime parameters for gRPC methods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds method lifetime info so consuming libraries (tocin) can populate types with correct lifetime info.