Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,11 @@ RUN apt-get update && apt-get install -y --no-install-recommends \
git \
&& rm -rf /var/lib/apt/lists/*

COPY --from=ghcr.io/php/pie:bin /pie /usr/bin/pie
COPY --from=composer /usr/bin/composer /usr/bin/composer
Comment on lines +25 to +26
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
COPY --from=ghcr.io/php/pie:bin /pie /usr/bin/pie
COPY --from=composer /usr/bin/composer /usr/bin/composer
COPY --link --from=ghcr.io/php/pie:bin /pie /usr/bin/pie
COPY --link --from=composer /usr/bin/composer /usr/bin/composer

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not composer/composer:latest-bin? See https://getcomposer.org/doc/00-intro.md#docker-image


RUN set -eux; \
install-php-extensions \
@composer \
apcu \
intl \
opcache \
Expand Down Expand Up @@ -60,10 +62,7 @@ ENV FRANKENPHP_WORKER_CONFIG=watch

RUN mv "$PHP_INI_DIR/php.ini-development" "$PHP_INI_DIR/php.ini"

RUN set -eux; \
install-php-extensions \
xdebug \
;
RUN pie install xdebug/xdebug

COPY --link frankenphp/conf.d/20-app.dev.ini $PHP_INI_DIR/app.conf.d/

Expand Down
Loading