Fix invalid SQL and incomplete viz options in dashboard example#9
Open
Lexirieru wants to merge 1 commit into
Open
Fix invalid SQL and incomplete viz options in dashboard example#9Lexirieru wants to merge 1 commit into
Lexirieru wants to merge 1 commit into
Conversation
The "Build a Dashboard from Scratch" example in SKILL.md had two issues that would cause the workflow to fail if followed verbatim. First, the SQL referenced FROM trades (no such table) with SUM(amount) (no such column) and had no partition filter on block_time. This violates the skill's own partition filter rule in dunesql-cheatsheet.md. Fixed to use dex.trades with amount_usd and a 30-day partition filter. Second, the chart --options JSON omitted required fields (sortX, seriesOptions, xAxis, yAxis, legend, series) listed in visualization-management.md. The file itself flags missing seriesOptions as a common mistake. Aligned the example with the minimum required template in the reference.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The "Build a Dashboard from Scratch" example in
skills/dune/SKILL.mdhad two issues that would cause the workflow to fail if followed verbatim.Invalid SQL. The example used
FROM trades(no such table) withSUM(amount)(no such column) and no partition filter onblock_time, violating the skill's own partition filter rule indunesql-cheatsheet.md. Fixed to usedex.tradeswithamount_usdand a 30-day partition filter.Incomplete chart options. The
--optionsJSON omitted the required fieldssortX,seriesOptions,xAxis,yAxis,legend, andserieslisted invisualization-management.md. The file itself flags missingseriesOptionsas a common mistake. Aligned the example with the minimum required template in the reference.Test plan
dune query run-sqlto confirmdex.trades.amount_usdresolves and the query completesdune viz createwith the updated--optionsJSON and verify the resulting chart renders correctly