Fix when a node has no childs #26
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When en element of type Node has no childs, the root of the node is returned by getDirectoryAsync. This generates an infinite loop where the same function is called. By returning the element and not the root, this properly detects that there is no child and finishes that branch of the tree.
Here's the log displayed in a loop:
And here's what is returned with the change:
I also attached the generated json. I only could get it with the fix as the json file is saved at the end and because of the loop, it never ends.
The fix is based on version3 branch.
fix_loop_when_nochild.json