Merged
Conversation
On Elixir 1.12 it's emitting annoying Supervision module warnings from bypass. It can easiliy be fixed by upgrading Bypass, and everything keeps working alright.
ulissesalmeida
requested review from
cachemoi,
enginoid,
joladev and
lbighetti
joladev
approved these changes
Oct 8, 2021
|
@ulissesalmeida, would you please propose these changes upstream when you can. I'm worried that we've fallen into maintaining this library. |
Author
|
Yeah, this one I created a Pr for the original library yesterday: |
angelcarballo
pushed a commit
that referenced
this pull request
Sep 8, 2022
On Elixir 1.12 it's emitting annoying Supervision module warnings from bypass. It can easiliy be fixed by upgrading Bypass, and everything keeps working alright.
ulissesalmeida
pushed a commit
that referenced
this pull request
Nov 16, 2022
On Elixir 1.12 it's emitting annoying Supervision module warnings from bypass. It can easiliy be fixed by upgrading Bypass, and everything keeps working alright.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Elixir 1.12 it's emitting annoying Supervision
module warnings from bypass. It can easiliy be fixed
by upgrading Bypass, and everything keeps working alright.