Row decorators with conditions#50
Open
rodrigo-martinez wants to merge 3 commits intodudapiotr:masterfrom
Open
Conversation
Author
|
I found the addVarClass that is cleaned after each row rendered. So changing de ClassDecorator instead of using de addClass use the addVarClass |
|
This change seems useful, could it be merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The renderer of rows is not validating the conditions before calling the decorator. As in the rendered of Cells, an if is needed who ask for the validConditions before calling the decorator.
Beside this, when added a ClassDecorator with conditions, the decorator adds the new class to the class attribute of row, so after that the class is added for every next rows. I don't know the best way to fix this, in the code, I added at the begining of the foreach an assigment to reset the class value.