Add support for path-like file name in to_csv and to_parquet#527
Open
leostimpfle wants to merge 1 commit into
Open
Add support for path-like file name in to_csv and to_parquet#527leostimpfle wants to merge 1 commit into
to_csv and to_parquet#527leostimpfle wants to merge 1 commit into
Conversation
NickCrews
reviewed
Jul 7, 2026
| }; | ||
|
|
||
| void PathLikeProcessor::AddFile(const nb::object &object) { | ||
| bool TryDecodePath(const nb::object &object, string &result) { |
Contributor
There was a problem hiding this comment.
nit: rename to TryEnsurePathString ("Ensure" implies that it can handle an already-string, "Decode" makes it sound like it can only handle Paths)
NickCrews
reviewed
Jul 7, 2026
NickCrews
left a comment
Contributor
There was a problem hiding this comment.
LGTM, two small nits that are non blockers for me (I'm not a maintainer though)
| return false; | ||
| } | ||
|
|
||
| string PathToString(const nb::object &object) { |
Contributor
There was a problem hiding this comment.
nit: rename to EnsurePathString (or whatever you end up with for the function above, without the "Try" prefix)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for
os.PathLikeoutput filenames in theDuckDBPyRelation.to_csvandDuckDBPyRelation.to_parquetmethods.Currently, only plain Python strings are supported which requires explicit casting of
pathlib.Pathobjects.The core change is the addition of PathToString which is used in DuckDBPyRelation::ToCSV and DuckDBPyRelation::ToParquet. I have added tests in tests/fast/api/test_to_csv.py and tests/fast/api/test_to_parquet.py for the new argument types.
@evertlammerts Please let me know any comments. I have a few further ideas on similar small-ish improvements to
duckdb-pythonwhich I would love to work on. (Please let me know if I should always first open discussions before PRs.)