Skip to content

Fix manager refreshing bundle #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sntran wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix manager refreshing bundle #19

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions lib/bundleManager.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,8 @@ var BundleManager = function() {

_.each(files, function(file, idx) {

// Make sure we ignore non-js files, dotfiles, packae.json and config.json
if (file.indexOf('.js') !== -1 && file.indexOf('package.json') === -1 && file.indexOf('config.json') === -1 && (file[0] !== '.' || (targetFile && targetFile.indexOf(file) != -1 ))) {
// Make sure we ignore non-js files, package.json and config.json
if (file.indexOf('.js') !== -1 && file.indexOf('package.json') === -1 && file.indexOf('config.json') === -1) {
// if any part fo the bundle is not valid js an error will be thrown and we ignore the rest of the file
try {
var tempBundle = require(bundlesFolder + "/" + file);
Expand Down Expand Up @@ -109,7 +109,7 @@ var BundleManager = function() {
winston.event('Bundle file changed: ' + file);

// To bust node's module caching we rename the file before calling updateBundle
var tempFile = '.'+uuid.v4();
var tempFile = file+'.'+uuid.v4();
fs.renameSync(file, tempFile);
self.refreshBundles(tempFile, function() {
// Now we can change the bundle name back to its original name
Expand Down