Draft
Conversation
dteviot
reviewed
Feb 17, 2026
| await addCssFileToZip(zip, "autoDark.css"); | ||
| let fileList = await getFileList("../plugin/popup.html"); | ||
| let localeNames = await getLocaleFilesNames(); | ||
| ["js/ContentScript.js"].concat(localeNames).concat(fileList.filter(n => !n.includes("/experimental/"))); |
Owner
There was a problem hiding this comment.
I think this needs to be
fileList = ["js/ContentScript.js"].concat(localeNames).concat(fileList.filter(n => !n.includes("/experimental/")));So that next line processes the correct list of files
|
|
||
| getChapterUrls(dom, chapterUrlsUI) { | ||
| return this.getChapterUrlsFromMultipleTocPages(dom, | ||
| async getChapterUrls(dom, chapterUrlsUI) { |
Owner
There was a problem hiding this comment.
Pretty sure this needs to be
return (await this.getChapterUrlsFromMultipleTocPages(dom,
ComrademaoParser.extractPartialChapterList,
ComrademaoParser.getUrlsOfTocPages,
chapterUrlsUI
)).reverse();| let nextUrl = QinxiaoshuoParser.urlOfNextPageOfChapter(xhr.responseXML, fetchedUrls); | ||
| return QinxiaoshuoParser.fetchPagesOfChapter(finalDom, fetchedUrls, nextUrl); | ||
| }); | ||
| let xhr = await HttpClient.wrapFetch(url); |
Owner
There was a problem hiding this comment.
This is using recursion due to use of then. Can be re-written as simple iteration.
| }.bind(this)); | ||
| async responseToJson(response) { | ||
| let data = await response.text(); | ||
| this.json = JSON.parse(data); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change the rest of the
.then()s to async-await.Ran the tests on the first commit, where there are no changes to the test files, and got all the tests to pass.
It's late, and I haven't given the code a once-over for style mistakes, so leaving this as a draft for now.