For information

[cheme]

Two commits, not sure you will be interested by the second (I added some genericity to try to reuse kvnode on some of my code), the first could be a starting point for update to rust nightly.

[dtantsur]

Would be nice to add some documentation comments

[dtantsur]

Hi @cheme, thank you for contributing! I've been pretty busy this weak, and I'll definitely review this code very soon, but not today :)

Being generic is rarely bad, I still need to figure out how it's going to work for Peer trait. Maybe we should leave Node as a base thingy, but make it generic over ID type. Not sure that we'll need different peer implementations, do you have a use case?

I'll probably understand it once I get some good sleep :)

Cheers

P.S.
No idea why github didn't notify me about this PR by email. Sorry for delay...

[dtantsur]

accepted first commit (3a98c43) into master, as it seems non-contradictive enough. Will review the remaining later..

[dtantsur]

Why is this commented out?

[dtantsur]

Hi again! I've also cherry-picked the last commit (except for commenting stuff). Now it builds, thanks a lot for your efforts! Version 0.0.1 released.
Please rebase, if you want to discuss genericity.

Cheers

[cheme]

Hi,

thanks for looking and updating,

I am currently trying to implement a generic library for implementing
some "distributed table" (not only hash table), and I use for peer and
content a generic interface : KeyVal which only defines a key/id and
the ability to get a socket address, that is why I tried to run it
with KNodeTable (using it as a routing option).

In fact, I had to define an other trait to link it : to convert key to
bigint, so I think part of the generic code is a bit awkward.

I'll let you know if my implementation become clean enough to publish.

Émeric

2015-02-06 19:07 UTC+01:00, Dmitry Tantsur notifications@github.com:

Hi again! I've also cherry-picked the last commit (except for commenting
stuff). Now it builds, thanks a lot for your efforts! Version 0.0.1
released.
Please rebase, if you want to discuss genericity.

Cheers

---

Reply to this email directly or view it on GitHub:
#1 (comment)