Open
Conversation
These are mostly example files copied from the Rcpp package.
Author
|
Hi @jaideep777 - yeah, there are a few files that we both touched, like gitignore and such, but I didn't touch actual logic, so a merge shouldn't be painful. I'll be focusing on my proposal for the coming weeks, so likely won't check back here until August. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @dsval
As mentioned in the thread at jaideep777@05dc5ce, I'd like to contribute to your project with this PR. Some of the changes are a little opinionated, but as the whole devtools/roxygen/pkgbuild toolchain is well established by now, and since apparently you already worked in VS code on this repo, I feel comfortable asking you to consider these changes.
If you feel comfortable with these contributions, I would gladly resolve some further namespace ambiguities, start to add test cases, and remove dead code, either in this PR or a separate one. You decide.
As I mentioned, I err on the side of collaboration, but if you'd rather not bother with PRs, I totally understand. Time is precious.
Best
Jan
Also tagging @jaideep777, even if he might not want to use the R environment.