Open
Conversation
Creates a new pair of classifiers, CatInATree and CatInAForest, that respect categoricals when randomly sampling features.
remove the min_impurity_decrease parameter from DecisionTreeClassifier call to conform to sklearn 0.18
Codecov Report
@@ Coverage Diff @@
## master #34 +/- ##
==========================================
+ Coverage 91.23% 91.23% +<.01%
==========================================
Files 13 13
Lines 844 993 +149
==========================================
+ Hits 770 906 +136
- Misses 74 87 +13
Continue to review full report at Codecov.
|
for non-categorical columns where imputation was performed, ensure the flag and underlying column always come together for models that respect categoricals (in the future, we may want to consider passing these separately but for the purposes here we just add them in with the categoricals)
Contributor
Author
|
@hakoenig made the good point that with the new imputation branch we should also ensure that imputed flags always get picked up along with their underlying columns, so pushed a quick change that adds those groupings in here as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR creates a new pair of classifiers,
CatInATreeandCatInAForest, that respect categoricals when randomly sampling features. A few notes:_trainmethod ofModelTrainerto pass these detected column groupings.