Fixed for newer .net and .net framework and msbuilds#67
Open
mitchcapper wants to merge 7 commits intodsplaisted:masterfrom
Open
Fixed for newer .net and .net framework and msbuilds#67mitchcapper wants to merge 7 commits intodsplaisted:masterfrom
mitchcapper wants to merge 7 commits intodsplaisted:masterfrom
Conversation
Author
cmconti
reviewed
Mar 21, 2024
src/StrongNamer/StrongNamer.csproj
Outdated
| <ItemGroup> | ||
| <PackageReference Include="Mono.Cecil" Version="$(CecilVersion)" PrivateAssets="all" /> | ||
| <PackageReference Include="Nerdbank.GitVersioning" Version="3.0.26" PrivateAssets="all" /> | ||
| <PackageReference Include="Mono.Cecil" Version="0.11.5" PrivateAssets="all" /> |
Author
There was a problem hiding this comment.
It wouldn't hurt anything but I don't think you gain anything either. The variable isn't used elsewhere and I don't see in Mono.cecil source itself.
There was a problem hiding this comment.
It's used in the None Include lines above
Author
There was a problem hiding this comment.
Good catch will update the pr with the fix
|
Is it probable that this code will be merge into the master branch in the near future? |
Author
|
This repo hasn't been touched in 5 years, I wouldn't hold your breath. I did add @cmconti 's fix though |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a few bugs (ie clean not cleaning out signed binaries), where the output binary would sometimes not take the newer signed version, avoids using reference dll's (note this part is a bit hacky it could be made more robust if it fails), and signature /runtime updates to make this work again. Several of Petar's multi-targeting commits as well.