Skip to content

chore: setting up the project#2

Closed
Srish-ty wants to merge 11 commits intodscnitrourkela:mainfrom
Srish-ty:chore/setup
Closed

chore: setting up the project#2
Srish-ty wants to merge 11 commits intodscnitrourkela:mainfrom
Srish-ty:chore/setup

Conversation

@Srish-ty
Copy link
Copy Markdown
Member

@Srish-ty Srish-ty commented Jun 3, 2024

Following changes are added by this pull_request:

  • Set up react project with pnpm as package manager
  • added prettier and eslint scripts for formatting and workflows

@Srish-ty
Copy link
Copy Markdown
Member Author

Srish-ty commented Jun 3, 2024

@Shurtu-gal please review

Copy link
Copy Markdown
Member

@Shurtu-gal Shurtu-gal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also maybe we could use vite or sth else to setup the react project. For reference:- reactjs/react.dev#5487 (comment)

Comment thread src/components/styles/Navbar.styles.jsx Outdated
Comment thread settings.json
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this should be in .vscode. And could you explain the settings purposes.

Copy link
Copy Markdown
Member Author

@Srish-ty Srish-ty Jun 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The scripts (pnpm lint) for eslint were giving error : no file found with \"src/**/*.{js,jsx}\" format without the settings.json

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But this should be in .vscode if I am not wrong.

Comment thread README.md
@Srish-ty Srish-ty requested a review from Shurtu-gal June 4, 2024 11:30
Copy link
Copy Markdown
Member

@Shurtu-gal Shurtu-gal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is still left #2 (review)

Comment thread README.md
Comment thread babel.config.json
@@ -0,0 +1,8 @@
{
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this still required?

Comment thread settings.json
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But this should be in .vscode if I am not wrong.

@Srish-ty
Copy link
Copy Markdown
Member Author

Srish-ty commented Jun 4, 2024

Also maybe we could use vite or sth else to setup the react project. For reference:- reactjs/react.dev#5487 (comment)

set new project up using vite.
pr link:

@Shurtu-gal Shurtu-gal closed this Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants