Guard against @subqueries being empty#4
Open
pivotalneutron wants to merge 2 commits intodsboulder:masterfrom
Open
Guard against @subqueries being empty#4pivotalneutron wants to merge 2 commits intodsboulder:masterfrom
pivotalneutron wants to merge 2 commits intodsboulder:masterfrom
Conversation
added 2 commits
May 5, 2011 17:41
For queries without subqueries (ie: UPDATE), calling SqlQuery#table raises a NoMethodError, since @subqueries is an empty array and [].first returns nil. This happens if such a query triggers a warning (see SqlQuery#warn).
jdelStrother
pushed a commit
to jdelStrother/query_reviewer
that referenced
this pull request
Sep 8, 2013
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For queries without subqueries (ie: UPDATE), calling SqlQuery#table raises a
NoMethodError, since @subqueries is an empty array and [].first returns nil.
This happens if such a query triggers a warning (see SqlQuery#warn).
(We wanted to include a unit test, but they don't seem to be in working order.)