Open
Conversation
Adding tests and documentation to MonoWave feature
Author
|
Approved |
drstevendev
reviewed
Jul 6, 2023
Owner
drstevendev
left a comment
drstevendev
left a comment
There was a problem hiding this comment.
thanks a lot for this improvement docu and test wise
drop a mail if you are interested in deeper conversation e.g. telegram to push the code further to a more usable state from a practical point of view, e.g. scanning markets :-)
| @@ -0,0 +1,12 @@ | |||
| # Copyright (c) 2023 Nightingale Professional Services, LLC | |||
Owner
There was a problem hiding this comment.
please remove this commercial licence text
Owner
There was a problem hiding this comment.
you can remove the cached (gitignore pycache) files from git, or are they commited on purpose?
|
|
||
| self.count = int # the count of the monowave, e.g. 1, 2, A, B, etc | ||
| self.degree = 1 # 1 = lowest timeframe level, 2 as soon as a e.g. 12345 is found etc. | ||
| self.count = int |
Owner
There was a problem hiding this comment.
should be more like .count = 0 or .count: int as type hint not assigned to class int (but i know that its old code anyway and i m overdue to clean it up myself :-) )
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding tests and documentation to MonoWave feature